Turso support#581
Open
eynopv wants to merge 4 commits into
Open
Conversation
|
@amacneil this would be a very welcome addition. |
Author
|
I’m happy to finish this PR. I just need clarification on what needs to be done for this to go forward and for the contribution to be accepted. |
|
@amacneil any chance you could give this a review? I'm eager to use it as well... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds basic support for Turso.
Current implementation does not include database creation and deletion as connection to Turso happens with their provided urls in following format:
libsql://[databaseName]-[organizationName].turso.ioIt would have been nice to parse the url by
-, but bothdatabaseNameandorganizationNamecan contain-character.To support database creation and drop, the format for
DATABASE_URLcan be changed toturso://[organizationName]/[databaseName]and then build the connection string from that, if it's something desired.It's also worth noting that database can belong to a group and could be added to the
DATABASE_URL.