Do not create migrations table on dump#701
Open
MatthiasKunnen wants to merge 1 commit into
Open
Conversation
MatthiasKunnen
changed the title
MatthiasKunnen
changed the title
MatthiasKunnen
force-pushed
the
dump-no-changes
branch
from
0e68950 to
829d216
Compare
When running dbmate dump, no changes to the database should be made.
MatthiasKunnen
force-pushed
the
dump-no-changes
branch
from
829d216 to
ddb60ec
Compare
dossy
requested changes
Feb 11, 2026
| err := db.Drop() | ||
| require.NoError(t, err) | ||
|
|
||
| // create and migrate |
Collaborator
There was a problem hiding this comment.
nit: create and don't migrate
| func (drv *Driver) schemaMigrationsDump(db *sql.DB) ([]byte, error) { | ||
| exists, err := drv.MigrationsTableExists(db) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to check if migration table exists: %w", err) |
Collaborator
There was a problem hiding this comment.
This doesn't appear to be a failure to check (we just tried to), but that we were unable to verify the existence of the migrations table? Saying "failed to check" seems a bit misleading here.
Would return nil, err be sufficient here, assuming that the error being returned from MigrationsTableExists() is well-formed?
| func (drv *Driver) schemaMigrationsDump(db *sql.DB, buf *bytes.Buffer) error { | ||
| exists, err := drv.MigrationsTableExists(db) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to check if migration table exists: %w", err) |
Collaborator
There was a problem hiding this comment.
See previous comment about returning err as-is.
| func (drv *Driver) schemaMigrationsDump(db *sql.DB) ([]byte, error) { | ||
| exists, err := drv.MigrationsTableExists(db) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to check if migration table exists: %w", err) |
Collaborator
There was a problem hiding this comment.
See previous comment about returning err as-is.
| func (drv *Driver) schemaMigrationsDump(db *sql.DB) ([]byte, error) { | ||
| exists, err := drv.MigrationsTableExists(db) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to check if migration table exists: %w", err) |
Collaborator
There was a problem hiding this comment.
See previous comment about returning err as-is.
| func (drv *Driver) schemaMigrationsDump(db *sql.DB) ([]byte, error) { | ||
| exists, err := drv.MigrationsTableExists(db) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to check if migration table exists: %w", err) |
Collaborator
There was a problem hiding this comment.
See previous comment about returning err as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
dbmate dump, no changes to the database should be made.Use case: running
dbmate dumpwith credentials that do not have CREATE permissions.