Skip to content

fix(doctor): probe real provider binary (claude/codex), not the provider key #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dk96-creator wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(doctor): probe real provider binary (claude/codex), not the provider key #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,15 +559,18 @@ def provider_valid() -> bool:
# otherwise the row is noise on top of the LLM_PROVIDER valid failure.
if Config.LLM_PROVIDER in valid_providers:
provider = Config.LLM_PROVIDER
# The provider key ("claude-cli"/"codex-cli") is not the binary name —
# the client shells out to "claude"/"codex" (see utils/llm_client.py).
provider_binary = {"claude-cli": "claude", "codex-cli": "codex"}[provider]

def provider_binary_on_path() -> bool:
return shutil.which(provider) is not None
return shutil.which(provider_binary) is not None

checks.append(
DoctorCheck(
name=f"{provider} binary on PATH",
name=f"{provider_binary} binary on PATH",
check=provider_binary_on_path,
hint=f"install the {provider} binary or add it to PATH",
hint=f"install the {provider_binary} binary or add it to PATH",
)
)

Expand Down