harden special_meeting

Author: vans163

ex/lib/consensus/special_meeting/special_meeting_gen.ex

@@ -112,17 +112,23 @@ defmodule SpecialMeetingGen do
 
   def handle_info({:add_slash_trainer_entry_reply, entry_hash, pk, signature}, state = %{slash_trainer: _}) do
     st = state.slash_trainer
-    true = st.entry.hash == entry_hash
-    if pk in st.validators do
-      aggsig = BLS12AggSig.add_padded(st.entry.aggsig, st.validators, pk, signature)
-      state = put_in(state, [:slash_trainer, :entry, :aggsig], aggsig)
-      IO.inspect {:entry, st.aggsig.mask_set_size / st.aggsig.mask_size}
-      {:noreply, state}
-    else
-      {:noreply, state}
+    cond do
+      !st[:entry] or !st.entry[:entry] -> {:noreply, state}
+      st.entry.entry.hash != entry_hash -> {:noreply, state}
+      pk not in st.validators -> {:noreply, state}
+      true ->
+        aggsig = BLS12AggSig.add_padded(st.entry.aggsig, st.validators, pk, signature)
+        state = put_in(state, [:slash_trainer, :entry, :aggsig], aggsig)
+        IO.inspect {:entry, aggsig.mask_set_size / aggsig.mask_size}
+        {:noreply, state}
     end
   end
 
+  def handle_info(msg, state) do
+    IO.inspect {:unknown_special_meeting_msg, msg}
+    {:noreply, state}
+  end
+
   def tick(state) do
     #IO.inspect state[:slash_trainer]
     st = state[:slash_trainer]

ex/lib/node/node_state.ex

@@ -188,22 +188,25 @@ defmodule NodeState do
   def handle(:special_business_reply, istate, term) do
     #IO.inspect {:special_business_reply, term.business}
     op = term.business.op
+    validators = DB.Chain.validators_for_height(DB.Chain.height() + 1) || []
     cond do
       #istate.peer.pk != <<>> -> nil
       op == "slash_trainer_tx_reply" ->
         b = term.business
         msg = <<"slash_trainer", b.epoch::32-little, b.malicious_pk::binary>>
-        sigValid = BlsEx.verify?(b.pk, b.signature, msg, BLS12AggSig.dst_motion())
+        sigValid = b.pk in validators and BlsEx.verify?(b.pk, b.signature, msg, BLS12AggSig.dst_motion())
         if sigValid do
           send(SpecialMeetingGen, {:add_slash_trainer_tx_reply, term.business.pk, term.business.signature})
         end
 
       op == "slash_trainer_entry_reply" ->
         b = term.business
-        sigValid = BlsEx.verify?(b.pk, b.signature, b.entry_hash, BLS12AggSig.dst_entry())
+        sigValid = b.pk in validators and BlsEx.verify?(b.pk, b.signature, b.entry_hash, BLS12AggSig.dst_entry())
         if sigValid do
           send(SpecialMeetingGen, {:add_slash_trainer_entry_reply, b.entry_hash, b.pk, b.signature})
         end
+
+      true -> nil
     end
   end