Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Better BadRequestException for Non Support Resources #26

@jfuss

Description

@jfuss

SAM CLI was cut this issue, which outputs a stack trace when Unsupported Resources are within the template that is being published.

I think it makes sense to include some additional error handling within this library that provides a better error that the boto3 error that gets returned. This is similar to wrapping of the Botocore ClientError that this library already wraps.

Proposal

Add a UnsupportedResourcesError in exceptions.py. We can then catch botocore.errorfactory.BadRequestException in this try: except: block and wrap it in the UnsupportedResourcesError with a message of "The template contains unsupported resource types. [XX::XX::XX]", which can be parsed out of the exception.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions