This repository was archived by the owner on Sep 24, 2021. It is now read-only.
Allow environment variables to be passed into cloudwatch-adapter pod#67
Open
iainbowman wants to merge 1 commit into
Open
Allow environment variables to be passed into cloudwatch-adapter pod#67iainbowman wants to merge 1 commit into
iainbowman wants to merge 1 commit into
Conversation
ericlarssen-wf
approved these changes
Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
We have recently started to use k8s-cloudwatch-adapter in a production environment and have the requirement to inject environment variables into the "k8s-cloudwatch-adapter" pod. This PR adds an "env:" section to the deployment specification within the cloudwatch-adapter chart that will accept a list of key/value pairs, the values file has also been updated to include an example of how this could be used.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.