Update php-cs-fixer rules (#754)

Add rules to PHP CS Fixer to modify implicit null parameters to explicitly null.

Author: jasonhebert

.php-cs-fixer.php

@@ -157,6 +157,8 @@
         'no_whitespace_in_blank_line' => true,
         'non_printable_character' => true,
         'normalize_index_brace' => true,
+        'nullable_type_declaration' => ['syntax' => 'question_mark'],
+        'nullable_type_declaration_for_default_null_value' => true,
         'object_operator_without_whitespace' => true,
         'ordered_class_elements' => [
             'order' => [

src/AmazonPHP/SellingPartner/Configuration.php

@@ -29,8 +29,8 @@ public function __construct(
         private string $accessKey,
         private string $secretKey,
         private ?string $securityToken = null,
-        Extensions $extensions = null,
-        LoggerConfiguration $loggerConfiguration = null
+        ?Extensions $extensions = null,
+        ?LoggerConfiguration $loggerConfiguration = null
     ) {
         // https://github.com/amzn/selling-partner-api-docs/blob/main/guides/en-US/developer-guide/SellingPartnerApiDeveloperGuide.md#include-a-user-agent-header-in-all-requests
         $this->userAgent = 'Library amazon-php/sp-api-php (language=PHP ' . \phpversion() . '; Platform=' . \php_uname('s') . ' ' . \php_uname('r') . ' ' . \php_uname('m') . ')';
@@ -158,7 +158,7 @@ public function setLogLevel(string $api, string $operationMethod, string $logLev
         return $this;
     }
 
-    public function setSkipLogging(string $api, string $operation = null) : self
+    public function setSkipLogging(string $api, ?string $operation = null) : self
     {
         if ($operation !== null) {
             $this->loggerConfiguration->skipAPIOperation($api, $operation);
@@ -171,7 +171,7 @@ public function setSkipLogging(string $api, string $operation = null) : self
         return $this;
     }
 
-    public function setEnableLogging(string $api, string $operation = null) : self
+    public function setEnableLogging(string $api, ?string $operation = null) : self
     {
         if ($operation !== null) {
             $this->loggerConfiguration->enableAPIOperation($api, $operation);
@@ -184,7 +184,7 @@ public function setEnableLogging(string $api, string $operation = null) : self
         return $this;
     }
 
-    public function loggingEnabled(string $api, string $operation = null) : bool
+    public function loggingEnabled(string $api, ?string $operation = null) : bool
     {
         return !$this->loggerConfiguration->isSkipped($api, $operation);
     }

src/AmazonPHP/SellingPartner/Configuration/LoggerConfiguration.php

@@ -124,7 +124,7 @@ public function enableAPIOperation(string $api, string $operation) : self
         return $this;
     }
 
-    public function isSkipped(string $api, string|null $operation = null) : bool
+    public function isSkipped(string $api, ?string $operation = null) : bool
     {
         if (\in_array($api, $this->skippedAPIs, true)) {
             return true;

src/AmazonPHP/SellingPartner/Exception/ApiException.php

@@ -17,7 +17,7 @@ final class ApiException extends Exception
      * @param null|string[] $responseHeaders HTTP response header
      * @param null|\stdClass|string $responseBody HTTP decoded body of the server response either as \stdClass or string
      */
-    public function __construct(string $message = '', int $code = 0, protected ?array $responseHeaders = null, protected $responseBody = null, \Throwable $previousException = null)
+    public function __construct(string $message = '', int $code = 0, protected ?array $responseHeaders = null, protected $responseBody = null, ?\Throwable $previousException = null)
     {
         parent::__construct($message, $code, $previousException);
     }

src/AmazonPHP/SellingPartner/Model/APlus/AplusPaginatedResponse.php

@@ -100,7 +100,7 @@ class AplusPaginatedResponse implements \ArrayAccess, \JsonSerializable, \String
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['warnings'] = $data['warnings'] ?? null;
         $this->container['next_page_token'] = $data['next_page_token'] ?? null;

src/AmazonPHP/SellingPartner/Model/APlus/AplusResponse.php

@@ -95,7 +95,7 @@ class AplusResponse implements \ArrayAccess, \JsonSerializable, \Stringable, Mod
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['warnings'] = $data['warnings'] ?? null;
     }

src/AmazonPHP/SellingPartner/Model/APlus/AsinMetadata.php

@@ -120,7 +120,7 @@ class AsinMetadata implements \ArrayAccess, \JsonSerializable, \Stringable, Mode
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['asin'] = $data['asin'] ?? null;
         $this->container['badge_set'] = $data['badge_set'] ?? null;

src/AmazonPHP/SellingPartner/Model/APlus/ContentDocument.php

@@ -115,7 +115,7 @@ class ContentDocument implements \ArrayAccess, \JsonSerializable, \Stringable, M
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['name'] = $data['name'] ?? null;
         $this->container['content_type'] = $data['content_type'] ?? null;

src/AmazonPHP/SellingPartner/Model/APlus/ContentMetadata.php

@@ -115,7 +115,7 @@ class ContentMetadata implements \ArrayAccess, \JsonSerializable, \Stringable, M
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['name'] = $data['name'] ?? null;
         $this->container['marketplace_id'] = $data['marketplace_id'] ?? null;

src/AmazonPHP/SellingPartner/Model/APlus/ContentMetadataRecord.php

@@ -100,7 +100,7 @@ class ContentMetadataRecord implements \ArrayAccess, \JsonSerializable, \Stringa
      * @param null|mixed[] $data Associated array of property values
      *                           initializing the model
      */
-    public function __construct(array $data = null)
+    public function __construct(?array $data = null)
     {
         $this->container['content_reference_key'] = $data['content_reference_key'] ?? null;
         $this->container['content_metadata'] = $data['content_metadata'] ?? null;