Enable multiple ips for mlx5 devices

We need to recognize a new device type on our instances. This
device type should be automatically brought up and able to query IMDS
for multiple IPs as is the case for ena. To do this we:

Create a separate network file for mlx5 devices and add the mlx5_core
driver type to the match for policy routes.

Testing:
- Built and installed rpm/deb packages for AL2023/Ubuntu respectively
- Launched AL2023/Ubuntu with package installed into ami
- For fresh instance, install on existing instance, and reboot -->
  validated that we see multiple IPs and the correct MTU of 8500 for
  each secondary interface

Author: Avtesh Singh

amazon-ec2-net-utils.spec

@@ -29,6 +29,7 @@ make install DESTDIR=%{buildroot} PREFIX=/usr
 
 %files
 /usr/lib/systemd/network/80-ec2.network
+/usr/lib/systemd/network/80-ec2-mlx5.network
 /usr/lib/systemd/system/policy-routes@.service
 /usr/lib/systemd/system/refresh-policy-routes@.service
 /usr/lib/systemd/system/refresh-policy-routes@.timer
@@ -64,9 +65,13 @@ net.ipv4.neigh.${iface}.retrans_time_ms=500
 net.ipv4.neigh.${iface}.ucast_solicit=0
 EOF
                 sysctl -p /etc/sysctl.d/90-ena-tuning-${iface}.conf >/dev/null || true
+                ;;
+        esac
+        case $ID_NET_DRIVER in
+            ena|ixgbevf|vif|mlx5_core)
                 systemctl restart policy-routes@${iface}.service
                 systemctl start refresh-policy-routes@${iface}.timer
-            ;;
+                ;;
         esac
     done
 }

debian/postinst

@@ -35,7 +35,7 @@ setup_policy_routes() {
         unset ID_NET_DRIVER
         eval $(udevadm info --export --query=property /sys/class/net/$iface)
         case $ID_NET_DRIVER in
-            ena|ixgbevf|vif)
+            ena|ixgbevf|vif|mlx5_core)
                 systemctl start policy-routes@${iface}.service
                 systemctl start refresh-policy-routes@${iface}.timer
                 ;;

lib/lib.sh

@@ -458,8 +458,14 @@ create_interface_config() {
     local network_card=$3
     local ether=$4
 
+    unset ID_NET_DRIVER
+    eval "$(udevadm info --export --query=property /sys/class/net/"$iface")"
+
     local libdir=/usr/lib/systemd/network
     local defconfig="${libdir}/80-ec2.network"
+    if [ "$ID_NET_DRIVER" = "mlx5_core" ]; then
+        defconfig="${libdir}/80-ec2-mlx5.network"
+    fi
 
     local -i retval=0
 

systemd/network/80-ec2-mlx5.network

@@ -0,0 +1,16 @@
+[Match]
+Driver=mlx5_core
+
+[Network]
+DHCP=yes
+IPv6DuplicateAddressDetection=0
+LLMNR=no
+DNSDefaultRoute=yes
+
+[DHCPv4]
+UseHostname=no
+UseDNS=yes
+UseNTP=yes
+UseDomains=yes
+UseGateway=true
+UseMTU=true

udev/99-vpc-policy-routes.rules

@@ -1,2 +1,2 @@
-SUBSYSTEM=="net", ACTION=="remove", ENV{ID_NET_DRIVER}=="vif|ena|ixgbevf", RUN+="/usr/bin/systemctl disable --now refresh-policy-routes@$name.timer policy-routes@$name.service"
-SUBSYSTEM=="net", ACTION=="add", ENV{ID_NET_DRIVER}=="vif|ena|ixgbevf", RUN+="/usr/bin/systemctl enable --now --no-block policy-routes@$name.service"
+SUBSYSTEM=="net", ACTION=="remove", ENV{ID_NET_DRIVER}=="vif|ena|ixgbevf|mlx5_core", RUN+="/usr/bin/systemctl disable --now refresh-policy-routes@$name.timer policy-routes@$name.service"
+SUBSYSTEM=="net", ACTION=="add", ENV{ID_NET_DRIVER}=="vif|ena|ixgbevf|mlx5_core", RUN+="/usr/bin/systemctl enable --now --no-block policy-routes@$name.service"