Skip to content

ux: add accessible labels and required validation to auth views #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ux: add accessible labels and required validation to auth views #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/amber_cli/templates/auth/src/views/session/new.ecr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@
<form action="/session" method="post">
<%="<"%>%= csrf_tag %>
<div class="form-group">
<input class="form-control" type="email" name="email" placeholder="Email"/>
<label for="email">Email</label>
<input class="form-control" type="email" name="email" id="email" placeholder="Email" required />
</div>
<div class="form-group">
<input class="form-control" type="password" name="password" placeholder="Password"/>
<label for="password">Password</label>
<input class="form-control" type="password" name="password" id="password" placeholder="Password" required />
</div>
<button class="btn btn-success btn-sm" type="submit">Sign In</button>
</form>
Expand Down
6 changes: 4 additions & 2 deletions src/amber_cli/templates/auth/src/views/session/new.slang.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ h1 Sign In
form action="/session" method="post"
== csrf_tag
.form-group
input.form-control type="email" name="email" placeholder="Email"
label for="email" Email
input.form-control type="email" name="email" id="email" placeholder="Email" required="true"
.form-group
input.form-control type="password" name="password" placeholder="Password"
label for="password" Password
input.form-control type="password" name="password" id="password" placeholder="Password" required="true"
button.btn.btn-success.btn-sm type="submit" Sign In
<hr/>
== link_to("Don't have an account yet?", "/signup")
3 changes: 2 additions & 1 deletion src/amber_cli/templates/auth/src/views/{{name}}/edit.ecr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
<input type="hidden" name="_method" value="patch" />

<div class="form-group">
<input class="form-control" type="email" name="email" placeholder="Email" value="<%="<"%>%= <%= @name %>.email %>" />
<label for="email">Email</label>
<input class="form-control" type="email" name="email" id="email" placeholder="Email" value="<%="<"%>%= <%= @name %>.email %>" />
</div>
<%="<"%>%= submit("Update", class: "btn btn-success btn-sm") %>
<%="<"%>%= link_to("Profile", "/profile", class: "btn btn-light btn-sm") %>
Expand Down
3 changes: 2 additions & 1 deletion src/amber_cli/templates/auth/src/views/{{name}}/edit.slang.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ h1 Edit Profile
== form(action: "/profile", method: :patch) do
== csrf_tag
.form-group
input.form-control type="email" name="email" placeholder="Email" value="#{<%= @name %>.email}"
label for="email" Email
input.form-control type="email" name="email" id="email" placeholder="Email" value="#{<%= @name %>.email}"
== submit("Update", class: "btn btn-success btn-sm")
== link_to("Profile", "/profile", class: "btn btn-light btn-sm")
6 changes: 4 additions & 2 deletions src/amber_cli/templates/auth/src/views/{{name}}/new.ecr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
<form action="/registration" method="post">
<%="<"%>%= csrf_tag %>
<div class="form-group">
<input class="form-control" type="email" name="email" placeholder="Email"/>
<label for="email">Email</label>
<input class="form-control" type="email" name="email" id="email" placeholder="Email" required />
</div>
<div class="form-group">
<input class="form-control" type="password" name="password" placeholder="Password"/>
<label for="password">Password</label>
<input class="form-control" type="password" name="password" id="password" placeholder="Password" required />
</div>
<button class="btn btn-success btn-sm" type="submit">Register</button>
</form>
Expand Down
6 changes: 4 additions & 2 deletions src/amber_cli/templates/auth/src/views/{{name}}/new.slang.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ h1 Sign Up
form action="/registration" method="post"
== csrf_tag
.form-group
input.form-control type="email" name="email" placeholder="Email"
label for="email" Email
input.form-control type="email" name="email" id="email" placeholder="Email" required="true"
.form-group
input.form-control type="password" name="password" placeholder="Password"
label for="password" Password
input.form-control type="password" name="password" id="password" placeholder="Password" required="true"
button.btn.btn-success.btn-sm type="submit"
| Register
<hr/>
Expand Down