Skip to content

Commit 4456c63

Browse files
markturanskyuserclaude
authored
fix: update mcp-proxy invocation for CLI breaking change in credential sidecars (#1629)
## Summary - `mcp-proxy`'s `-e` flag changed from `-e KEY` (single arg) to `-e KEY VALUE` (two args) - The old `-e GITHUB_PERSONAL_ACCESS_TOKEN` consumed `--port` as the VALUE, making `8091` the positional `command_or_url` arg, causing `FileNotFoundError: '8091'` at runtime - This crashed the credential-github sidecar container, making the pod 4/5 ready, which caused 502 Bad Gateway on session event streams - Replace `-e <KEY>` with `--pass-environment` in github and google sidecars since `credential-entrypoint` already sets the env vars before exec ## Test plan - [ ] CI credential sidecar builds pass - [ ] credential-github container starts without FileNotFoundError - [ ] credential-google container starts without FileNotFoundError - [ ] Session with GitHub credential sidecar reaches 5/5 ready pods 🤖 Generated with [Claude Code](https://claude.ai/code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Docker runtime configurations for credential sidecars to use improved environment variable handling mechanisms in containerized deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: user <u@example.com> Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2efb2db commit 4456c63

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

components/credential-sidecars/github/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ USER 1001
2727

2828
EXPOSE 8091
2929

30-
ENTRYPOINT ["credential-entrypoint", "mcp-proxy", "-e", "GITHUB_PERSONAL_ACCESS_TOKEN", "--port", "8091", "--"]
30+
ENTRYPOINT ["credential-entrypoint", "mcp-proxy", "--pass-environment", "--port", "8091", "--"]
3131
CMD ["github-mcp-server", "stdio"]

components/credential-sidecars/google/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ USER 1001
2424

2525
EXPOSE 8094
2626

27-
ENTRYPOINT ["credential-entrypoint", "mcp-proxy", "-e", "GOOGLE_ACCESS_TOKEN", "--port", "8094", "--"]
27+
ENTRYPOINT ["credential-entrypoint", "mcp-proxy", "--pass-environment", "--port", "8094", "--"]
2828
CMD ["python", "-m", "workspace_mcp", "--permissions", "gmail:send", "drive:full"]

0 commit comments

Comments
 (0)