Skip to content

Commit 577905a

Browse files
authored
mergify: remove coderabbit comment requirement (#941)
CodeRabbit does not leave a review if there are no actionable comments. When Mergify does not see the CodeRabbit review, it will not merge the PR, even if the PR meets all the other criteria (successful human review + passing tests). The purpose of adding coderabbit to the Mergify criteria is to provide a natural quality governer: to ensure that humans read the reviews. Turns out CodeRabbit is useful enough that we don't need to enforce this with Mergify, and tweaking it further is not worth optimizing. Fixes: #940
1 parent d2174f1 commit 577905a

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

.mergify.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ queue_rules:
66
- "#approved-reviews-by>=2"
77
- "#changes-requested-reviews-by=0"
88
- check-success=End-to-End Tests
9-
- commented-reviews-by=coderabbitai[bot]
109
- check-success=validate-manifests
1110
- check-success=test-local-dev-simulation
1211

@@ -17,7 +16,6 @@ queue_rules:
1716
- "#approved-reviews-by>=1"
1817
- "#changes-requested-reviews-by=0"
1918
- check-success=End-to-End Tests
20-
- commented-reviews-by=coderabbitai[bot]
2119
- check-success=validate-manifests
2220
- check-success=test-local-dev-simulation
2321

0 commit comments

Comments
 (0)