Commit 5b1e702
fix(runner): restore acp backend MCP tools as fallback when sidecar is absent (#1607)
## Summary
- PR #1593 removed the `acp` backend MCP server (9 session management
tools: `acp_list_sessions`, `acp_get_session`, `acp_create_session`,
`acp_stop_session`, `acp_send_message`, `acp_get_session_status`,
`acp_restart_session`, `acp_list_workflows`, `acp_get_api_reference`)
when adding dynamic credential-aware MCP servers
- The ambient MCP sidecar only provides equivalents for 5 of those 9
tools — `stop_session`, `restart_session`, `list_workflows`, and
`get_api_reference` have no sidecar equivalent
- Sessions without the sidecar (e.g. older CPs, missing `MCP_IMAGE`
config, or `CP_TOKEN_URL`/`CPTokenPublicKey` not configured) lost
**all** session management tooling
- This re-registers the `acp` backend tools as a fallback when
`AMBIENT_MCP_URL` is not set. When the sidecar IS present, its tools
take precedence
## Test plan
- [x] 549/549 runner tests pass (1 pre-existing mlflow skip)
- [x] 66/66 MCP + backend_tools tests pass
- [ ] Deploy to staging and verify `acp_*` tools appear when sidecar is
absent
- [ ] Verify tools are NOT registered when sidecar IS present (no
duplicates)
🤖 Generated with [Claude Code](https://claude.ai/code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Backend API tools are now automatically available in more deployment
configurations, expanding functionality and flexibility.
* Improved logging now surfaces discovered backend tools and their
availability.
* **Tests**
* End-to-end scheduled-session test now uses a stubbed workflow API to
stabilize editing assertions and ensure OOTB workflow display and
custom-field hiding.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: user <u@example.com>
Co-authored-by: Claude <noreply@anthropic.com>1 parent d45e631 commit 5b1e702
2 files changed
Lines changed: 35 additions & 0 deletions
File tree
- components/runners/ambient-runner/ambient_runner/bridges/claude
- e2e/cypress/e2e
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
120 | 135 | | |
121 | 136 | | |
122 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
414 | 432 | | |
415 | 433 | | |
416 | 434 | | |
| 435 | + | |
| 436 | + | |
417 | 437 | | |
418 | 438 | | |
419 | 439 | | |
| |||
0 commit comments