Skip to content

Commit 5d96404

Browse files
maskarbclaude
andauthored
fix(ci): add ambient-api-server to deploy-to-openshift workflow (#867)
## Summary - The `deploy-to-openshift` and `deploy-with-dispatch` jobs were missing `ambient-api-server` from the change detection gate, image tag resolution, and kustomize image pinning - Changes to the api-server component would build but never deploy to OpenShift ## Test plan - [ ] Verify workflow syntax is valid (GitHub Actions lint) - [ ] Trigger a workflow_dispatch to confirm api-server image is included in deployment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent f981ed3 commit 5d96404

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

.github/workflows/components-build-deploy.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ jobs:
208208
deploy-to-openshift:
209209
runs-on: ubuntu-latest
210210
needs: [detect-changes, build-and-push, update-rbac-and-crd]
211-
if: github.event_name == 'push' && github.ref == 'refs/heads/main' && (needs.detect-changes.outputs.frontend == 'true' || needs.detect-changes.outputs.backend == 'true' || needs.detect-changes.outputs.operator == 'true' || needs.detect-changes.outputs.claude-runner == 'true' || needs.detect-changes.outputs.state-sync == 'true' || needs.detect-changes.outputs.public-api == 'true')
211+
if: github.event_name == 'push' && github.ref == 'refs/heads/main' && (needs.detect-changes.outputs.frontend == 'true' || needs.detect-changes.outputs.backend == 'true' || needs.detect-changes.outputs.operator == 'true' || needs.detect-changes.outputs.claude-runner == 'true' || needs.detect-changes.outputs.state-sync == 'true' || needs.detect-changes.outputs.public-api == 'true' || needs.detect-changes.outputs.ambient-api-server == 'true')
212212
steps:
213213
- name: Checkout code
214214
uses: actions/checkout@v6
@@ -267,6 +267,12 @@ jobs:
267267
echo "public_api_tag=stage" >> $GITHUB_OUTPUT
268268
fi
269269
270+
if [ "${{ needs.detect-changes.outputs.ambient-api-server }}" == "true" ]; then
271+
echo "api_server_tag=${{ github.sha }}" >> $GITHUB_OUTPUT
272+
else
273+
echo "api_server_tag=stage" >> $GITHUB_OUTPUT
274+
fi
275+
270276
- name: Update kustomization with image tags
271277
working-directory: components/manifests/overlays/production
272278
run: |
@@ -276,6 +282,7 @@ jobs:
276282
kustomize edit set image quay.io/ambient_code/vteam_claude_runner:latest=quay.io/ambient_code/vteam_claude_runner:${{ steps.image-tags.outputs.runner_tag }}
277283
kustomize edit set image quay.io/ambient_code/vteam_state_sync:latest=quay.io/ambient_code/vteam_state_sync:${{ steps.image-tags.outputs.state_sync_tag }}
278284
kustomize edit set image quay.io/ambient_code/vteam_public_api:latest=quay.io/ambient_code/vteam_public_api:${{ steps.image-tags.outputs.public_api_tag }}
285+
kustomize edit set image quay.io/ambient_code/vteam_api_server:latest=quay.io/ambient_code/vteam_api_server:${{ steps.image-tags.outputs.api_server_tag }}
279286
280287
- name: Validate kustomization
281288
working-directory: components/manifests/overlays/production
@@ -356,6 +363,7 @@ jobs:
356363
kustomize edit set image quay.io/ambient_code/vteam_claude_runner:latest=quay.io/ambient_code/vteam_claude_runner:stage
357364
kustomize edit set image quay.io/ambient_code/vteam_state_sync:latest=quay.io/ambient_code/vteam_state_sync:stage
358365
kustomize edit set image quay.io/ambient_code/vteam_public_api:latest=quay.io/ambient_code/vteam_public_api:stage
366+
kustomize edit set image quay.io/ambient_code/vteam_api_server:latest=quay.io/ambient_code/vteam_api_server:stage
359367
360368
- name: Validate kustomization
361369
working-directory: components/manifests/overlays/production

.github/workflows/prod-release-deploy.yaml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
type: boolean
1919
default: true
2020
components:
21-
description: 'Components to build (comma-separated: frontend,backend,operator,claude-runner,state-sync) - leave empty for all'
21+
description: 'Components to build (comma-separated: frontend,backend,operator,claude-runner,state-sync,public-api,ambient-api-server) - leave empty for all'
2222
required: false
2323
type: string
2424
default: ''
@@ -176,6 +176,14 @@ jobs:
176176
context: ./components/runners/state-sync
177177
image: quay.io/ambient_code/vteam_state_sync
178178
dockerfile: ./components/runners/state-sync/Dockerfile
179+
- name: public-api
180+
context: ./components/public-api
181+
image: quay.io/ambient_code/vteam_public_api
182+
dockerfile: ./components/public-api/Dockerfile
183+
- name: ambient-api-server
184+
context: ./components/ambient-api-server
185+
image: quay.io/ambient_code/vteam_api_server
186+
dockerfile: ./components/ambient-api-server/Dockerfile
179187
steps:
180188
- name: Checkout code from the tag generated above
181189
uses: actions/checkout@v6
@@ -253,6 +261,8 @@ jobs:
253261
kustomize edit set image quay.io/ambient_code/vteam_operator:latest=quay.io/ambient_code/vteam_operator:${RELEASE_TAG}
254262
kustomize edit set image quay.io/ambient_code/vteam_claude_runner:latest=quay.io/ambient_code/vteam_claude_runner:${RELEASE_TAG}
255263
kustomize edit set image quay.io/ambient_code/vteam_state_sync:latest=quay.io/ambient_code/vteam_state_sync:${RELEASE_TAG}
264+
kustomize edit set image quay.io/ambient_code/vteam_public_api:latest=quay.io/ambient_code/vteam_public_api:${RELEASE_TAG}
265+
kustomize edit set image quay.io/ambient_code/vteam_api_server:latest=quay.io/ambient_code/vteam_api_server:${RELEASE_TAG}
256266
257267
- name: Validate kustomization
258268
working-directory: components/manifests/overlays/production

0 commit comments

Comments
 (0)