Skip to content

Commit 9180a41

Browse files
mprpicclaude
andauthored
fix: re-apply JSON escaping in junit-summary custom_data (#837)
Commit 4f0b0a0 ("restore workflow consolidation reverted by PR #788") re-created unit-tests.yml but lost the JSON escaping fix from 56a196e. The unescaped curly braces and quotes in the custom_data parameter break the kubeflow/pipelines junit-summary action's bash conditional, causing the "Mark Workflow failure if test reporting failed" step to fail even when all tests pass. Signed-off-by: Martin Prpič <mprpic@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4f0b0a0 commit 9180a41

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/unit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
if: (!cancelled()) && steps.upload.outcome != 'failure'
148148
with:
149149
xml_files: '${{ env.TESTS_DIR }}/reports'
150-
custom_data: '{"HTML Report": "${{ steps.upload.outputs.artifact-url }}"}'
150+
custom_data: '{\"HTML Report\": \"${{ steps.upload.outputs.artifact-url }}\"}'
151151
continue-on-error: true
152152

153153
- name: Publish Test Summary

0 commit comments

Comments
 (0)