Skip to content

Commit 95e1ede

Browse files
maskarbclaude
andcommitted
ci: address second round of review feedback
- Add sync comment on arch suffixes that must match merge-manifests - Remove cache-to on PR builds to avoid evicting main-branch cache - Revert cosmetic backend banner change (CI trigger workaround) - Fix inconsistent 3-space job indent in prod-release-deploy.yaml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent fa86498 commit 95e1ede

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

.github/workflows/components-build-deploy.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ jobs:
146146
strategy:
147147
fail-fast: false
148148
matrix:
149+
# IMPORTANT: suffix values must match the hardcoded suffixes in
150+
# merge-manifests. Update both together if arches change.
149151
arch:
150152
- runner: ubuntu-latest
151153
platform: linux/amd64
@@ -200,7 +202,6 @@ jobs:
200202
push: false
201203
tags: ${{ matrix.component.image }}:pr-${{ github.event.pull_request.number }}-${{ matrix.arch.suffix }}
202204
cache-from: type=gha,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
203-
cache-to: type=gha,mode=max,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
204205

205206
merge-manifests:
206207
needs: [detect-changes, build]

.github/workflows/prod-release-deploy.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ concurrency:
2727
cancel-in-progress: false
2828

2929
jobs:
30-
release:
30+
release:
3131
runs-on: ubuntu-latest
3232
permissions:
3333
contents: write
@@ -177,7 +177,7 @@ jobs:
177177
echo "Components to build:"
178178
echo "$FILTERED" | jq -r '.[].name'
179179
180-
build:
180+
build:
181181
needs: release
182182
permissions:
183183
contents: read
@@ -187,6 +187,8 @@ jobs:
187187
strategy:
188188
fail-fast: false
189189
matrix:
190+
# IMPORTANT: suffix values must match the hardcoded suffixes in
191+
# merge-manifests. Update both together if arches change.
190192
arch:
191193
- runner: ubuntu-latest
192194
platform: linux/amd64
@@ -231,7 +233,7 @@ jobs:
231233
cache-from: type=gha,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
232234
cache-to: type=gha,mode=max,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
233235

234-
merge-manifests:
236+
merge-manifests:
235237
needs: [release, build]
236238
runs-on: ubuntu-latest
237239
permissions:
@@ -261,7 +263,7 @@ jobs:
261263
${{ matrix.component.image }}:${{ needs.release.outputs.new_tag }}-amd64 \
262264
${{ matrix.component.image }}:${{ needs.release.outputs.new_tag }}-arm64
263265
264-
deploy-to-openshift:
266+
deploy-to-openshift:
265267
runs-on: ubuntu-latest
266268
needs: [release, merge-manifests]
267269
steps:

components/backend/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ var (
2929
)
3030

3131
func logBuildInfo() {
32-
log.Println("================================================")
32+
log.Println("==============================================")
3333
log.Println("Backend API - Build Information")
34-
log.Println("================================================")
34+
log.Println("==============================================")
3535
log.Printf("Version: %s", GitVersion)
3636
log.Printf("Commit: %s", GitCommit)
3737
log.Printf("Branch: %s", GitBranch)

0 commit comments

Comments
 (0)