Skip to content

Commit 992f98f

Browse files
markturanskyuserclaudemergify[bot]
authored
fix: resolve kustomize 5.4.3 panic on ambient-ui delete patch (#1631)
## Summary - The `ambient-ui-delete-patch.yaml` uses `$patch: delete` at the YAML document root, which causes a nil pointer dereference (`RNode.Content() → GetApiVersion()`) in kustomize **5.4.3** (pinned in `prod-release-deploy.yaml`) - This panics the `Validate kustomization` step in the `deploy-to-openshift` job: https://github.com/ambient-code/platform/actions/runs/26817820753/job/79067010287 - Works on kustomize 5.8.0 but not 5.4.3 — the root-level `$patch: delete` in a multi-document file without explicit target selectors triggers the bug - Replace external patch file with inline `patch:` entries using explicit `target:` selectors, which kustomize resolves correctly across versions - Verified: `kustomize build` succeeds and ambient-ui resources are excluded from output ## Test plan - [ ] `kustomize build overlays/production` succeeds (no panic) - [ ] ambient-ui Deployment/ServiceAccount/Service are absent from built output - [ ] deploy-to-openshift CI job passes 🤖 Generated with [Claude Code](https://claude.ai/code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Removed the ambient-ui component from the production environment configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: user <u@example.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 4456c63 commit 992f98f

2 files changed

Lines changed: 31 additions & 18 deletions

File tree

components/manifests/overlays/production/ambient-ui-delete-patch.yaml

Lines changed: 0 additions & 17 deletions
This file was deleted.

components/manifests/overlays/production/kustomization.yaml

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,37 @@ patches:
5656
kind: PersistentVolumeClaim
5757
name: minio-data
5858
version: v1
59-
- path: ambient-ui-delete-patch.yaml
59+
- patch: |
60+
$patch: delete
61+
apiVersion: apps/v1
62+
kind: Deployment
63+
metadata:
64+
name: ambient-ui
65+
target:
66+
group: apps
67+
version: v1
68+
kind: Deployment
69+
name: ambient-ui
70+
- patch: |
71+
$patch: delete
72+
apiVersion: v1
73+
kind: ServiceAccount
74+
metadata:
75+
name: ambient-ui
76+
target:
77+
version: v1
78+
kind: ServiceAccount
79+
name: ambient-ui
80+
- patch: |
81+
$patch: delete
82+
apiVersion: v1
83+
kind: Service
84+
metadata:
85+
name: ambient-ui-service
86+
target:
87+
version: v1
88+
kind: Service
89+
name: ambient-ui-service
6090

6191
# Production images
6292
images:

0 commit comments

Comments
 (0)