Skip to content

Commit b4b4efe

Browse files
maskarbclaude
andcommitted
ci: address second round of review feedback
- Add sync comment on arch suffixes that must match merge-manifests - Remove cache-to on PR builds to avoid evicting main-branch cache - Revert cosmetic backend banner change (CI trigger workaround) - Fix inconsistent 3-space job indent in prod-release-deploy.yaml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5b9b1ff commit b4b4efe

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

.github/workflows/components-build-deploy.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ jobs:
153153
strategy:
154154
fail-fast: false
155155
matrix:
156+
# IMPORTANT: suffix values must match the hardcoded suffixes in
157+
# merge-manifests. Update both together if arches change.
156158
arch:
157159
- runner: ubuntu-latest
158160
platform: linux/amd64
@@ -207,7 +209,6 @@ jobs:
207209
push: false
208210
tags: ${{ matrix.component.image }}:pr-${{ github.event.pull_request.number }}-${{ matrix.arch.suffix }}
209211
cache-from: type=gha,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
210-
cache-to: type=gha,mode=max,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
211212

212213
merge-manifests:
213214
needs: [detect-changes, build]

.github/workflows/prod-release-deploy.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ concurrency:
2727
cancel-in-progress: false
2828

2929
jobs:
30-
release:
30+
release:
3131
runs-on: ubuntu-latest
3232
permissions:
3333
contents: write
@@ -176,7 +176,7 @@ jobs:
176176
echo "Components to build:"
177177
echo "$FILTERED" | jq -r '.[].name'
178178
179-
build:
179+
build:
180180
needs: release
181181
permissions:
182182
contents: read
@@ -186,6 +186,8 @@ jobs:
186186
strategy:
187187
fail-fast: false
188188
matrix:
189+
# IMPORTANT: suffix values must match the hardcoded suffixes in
190+
# merge-manifests. Update both together if arches change.
189191
arch:
190192
- runner: ubuntu-latest
191193
platform: linux/amd64
@@ -230,7 +232,7 @@ jobs:
230232
cache-from: type=gha,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
231233
cache-to: type=gha,mode=max,scope=${{ matrix.component.name }}-${{ matrix.arch.suffix }}
232234

233-
merge-manifests:
235+
merge-manifests:
234236
needs: [release, build]
235237
runs-on: ubuntu-latest
236238
permissions:
@@ -260,7 +262,7 @@ jobs:
260262
${{ matrix.component.image }}:${{ needs.release.outputs.new_tag }}-amd64 \
261263
${{ matrix.component.image }}:${{ needs.release.outputs.new_tag }}-arm64
262264
263-
deploy-to-openshift:
265+
deploy-to-openshift:
264266
runs-on: ubuntu-latest
265267
needs: [release, merge-manifests]
266268
steps:

components/backend/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ var (
2929
)
3030

3131
func logBuildInfo() {
32-
log.Println("================================================")
32+
log.Println("==============================================")
3333
log.Println("Backend API - Build Information")
34-
log.Println("================================================")
34+
log.Println("==============================================")
3535
log.Printf("Version: %s", GitVersion)
3636
log.Printf("Commit: %s", GitCommit)
3737
log.Printf("Branch: %s", GitBranch)

0 commit comments

Comments
 (0)