Commit cdc5aa0
fix: address CodeRabbit critical & accessibility feedback
- **CRITICAL**: Fix race condition in bridge.py by scoping halt state per-thread
- Added `_halted_by_thread` dict to track halt state separately for each thread_id
- Prevents concurrent runs from interfering with each other's halt detection
- Clears thread-specific halt flag after worker interrupt
- **Fix**: Clear in-flight tool-call state on halt in adapter.py
- Prevents duplicate ToolCallEndEvent emission in finally block
- Resets current_tool_call_id and related state when halting
- **Accessibility**: Add keyboard support to "Other" option in ask-user-question
- Added onKeyDown handler for Enter/Space keys
- Added tabIndex and role="button" for keyboard navigation
- Ensures compliance with a11y requirements
Addresses CodeRabbit review feedback from PR #871.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent c674b9d commit cdc5aa0
3 files changed
Lines changed: 26 additions & 1 deletion
File tree
- components
- frontend/src/components/session
- runners/ambient-runner
- ag_ui_claude_sdk
- ambient_runner/bridges/claude
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
218 | 226 | | |
219 | 227 | | |
220 | 228 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
919 | 919 | | |
920 | 920 | | |
921 | 921 | | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
922 | 930 | | |
923 | 931 | | |
924 | 932 | | |
| |||
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
121 | 123 | | |
122 | 124 | | |
123 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
124 | 130 | | |
125 | 131 | | |
126 | 132 | | |
127 | | - | |
| 133 | + | |
128 | 134 | | |
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
132 | 138 | | |
| 139 | + | |
| 140 | + | |
133 | 141 | | |
134 | 142 | | |
135 | 143 | | |
| |||
176 | 184 | | |
177 | 185 | | |
178 | 186 | | |
| 187 | + | |
179 | 188 | | |
180 | 189 | | |
181 | 190 | | |
| |||
0 commit comments