fix(frontend): restore chat history when returning to a session#1684
Merged
markturansky merged 2 commits intoJun 15, 2026
Merged
Conversation
Replace async params.then() + useState pattern with synchronous React.use(params) so projectName and sessionName are available from the first render. The previous pattern left both values as empty strings on mount, causing the AG-UI EventSource connection to be deferred until a second render cycle. On fast re-navigation this race could result in historical SSE events being missed and chat history not rendering. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSync param extraction via React use()
🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
params.then()+useStatewith synchronousReact.use(params)so route params are available from the first render, eliminating a race condition where the AG-UI EventSource connection was deferred and historical chat events were missed on re-navigationthread_id— was callingGET /events(404) instead ofGET /events/{sessionName}Root Cause
Chat history not rendering (frontend)
The session detail page extracted
projectNameandsessionNamefrom the asyncparamsPromise viauseEffect(() => { params.then(...) }), initializing both as empty strings. This meant the EventSource connection was deferred to a second render cycle. On fast re-navigation, the timing gap could cause the SSE replay of historical events to be missed.Between-run listener 404s (backend)
The
listenBetweenRunEventsfunction constructed the runner events URL asGET /eventswithout appending the thread_id path parameter. The runner endpoint requiresGET /events/{thread_id}, returning 404 on every attempt. This prevented capture of events emitted between user-initiated runs (e.g., background task completions).Test plan
GET /events 404entriescd components/frontend && npm run buildpasses with 0 errorscd components/backend && go vet ./...passes🤖 Generated with Claude Code