Skip to content

Commit 06d0eb2

Browse files
committed
Renamed endpoint_url to endpoint and getEndpointUrl() to getEndpointOverride() as requested in PR review
1 parent 45df620 commit 06d0eb2

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

data-prepper-plugins/dynamodb-source/src/main/java/org/opensearch/dataprepper/plugins/source/dynamodb/ClientFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public DynamoDbStreamsClient buildDynamoDbStreamClient() {
4545
.credentialsProvider(awsCredentialsProvider)
4646
.region(awsAuthenticationConfig.getAwsRegion());
4747

48-
if (awsAuthenticationConfig.getEndpointUrl() != null && !awsAuthenticationConfig.getEndpointUrl().isEmpty()) {
49-
clientBuilder.endpointOverride(URI.create(awsAuthenticationConfig.getEndpointUrl()));
48+
if (awsAuthenticationConfig.getEndpointOverride() != null && !awsAuthenticationConfig.getEndpointOverride().isEmpty()) {
49+
clientBuilder.endpointOverride(URI.create(awsAuthenticationConfig.getEndpointOverride()));
5050
}
5151

5252
return clientBuilder.build();
@@ -58,8 +58,8 @@ public DynamoDbClient buildDynamoDBClient() {
5858
.region(awsAuthenticationConfig.getAwsRegion())
5959
.credentialsProvider(awsCredentialsProvider);
6060

61-
if (awsAuthenticationConfig.getEndpointUrl() != null && !awsAuthenticationConfig.getEndpointUrl().isEmpty()) {
62-
clientBuilder.endpointOverride(URI.create(awsAuthenticationConfig.getEndpointUrl()));
61+
if (awsAuthenticationConfig.getEndpointOverride() != null && !awsAuthenticationConfig.getEndpointOverride().isEmpty()) {
62+
clientBuilder.endpointOverride(URI.create(awsAuthenticationConfig.getEndpointOverride()));
6363
}
6464

6565
return clientBuilder.build();

data-prepper-plugins/dynamodb-source/src/main/java/org/opensearch/dataprepper/plugins/source/dynamodb/configuration/AwsAuthenticationConfig.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ public class AwsAuthenticationConfig {
2929
@Size(max = 5, message = "sts_header_overrides supports a maximum of 5 headers to override")
3030
private Map<String, String> awsStsHeaderOverrides;
3131

32-
@JsonProperty("endpoint_url")
33-
@Size(min = 10, max = 2048, message = "endpoint_url length should be between 10 and 2048 characters")
34-
private String endpoint_url;
32+
@JsonProperty("endpoint")
33+
@Size(min = 10, max = 2048, message = "endpoint length should be between 10 and 2048 characters")
34+
private String endpoint;
3535

3636
public String getAwsStsRoleArn() {
3737
return awsStsRoleArn;
@@ -49,8 +49,8 @@ public Map<String, String> getAwsStsHeaderOverrides() {
4949
return awsStsHeaderOverrides;
5050
}
5151

52-
public String getEndpointUrl() {
53-
return endpoint_url;
52+
public String getEndpointOverride() {
53+
return endpoint;
5454
}
5555
}
5656

0 commit comments

Comments
 (0)