Pull Request for additions to the ImageMagick Section#487
Conversation
Added section detailing differences between ImageMagick versions 6 and 7, including command changes and additional resources.
| <label class="recipe" for="im_fconversion">Format conversion</label> | ||
| <input type="checkbox" id="im_fconversion"> | ||
| <div class="hiding"> | ||
| <h5>Format conversion</h5> | ||
| <p><code>convert <em>input_file.png output_file.jpg</em></code></p> | ||
| <p>Converts a file from one format to another.</p> | ||
| <dl> | ||
| <dt>convert</dt><dd>starts the command</dd> | ||
| <dt><em>input_file.ext output_file.ext</em></dt><dd>takes the input file format and converts it to the output file format. Although this example uses .png to .jpg any format conversion combination can be used so long as the formats are supported by Image Magick.</dd> | ||
| </dl> | ||
| <p> ★ImageMagick V7 command: <code>magick <em>input_file.png output_file.jpg</em></code></p> | ||
| <p class="link"></p> | ||
| </div> |
There was a problem hiding this comment.
Hello! thank you for the contribution 😸
These changes look good overall, but would you mind to indent the markup correctly, as in the other recipes?
(also below)
| <div class="hiding"> | ||
| <h5>Control the compression quality of an image</h5> | ||
| <p><code>mogrify -quality value image_file.ext</code></p> | ||
| <p><p>Controls the compression quality of JPEG, PNG, HEIC, and WebP image files.</p> |
There was a problem hiding this comment.
I presume, there is a <p> too much at the beginning?
|
I wanted to bump this one - @LUCIA224, are you still around? |
|
@retokromer @kfrn Thank you for taking the time to review this PR. I’m also commenting as the professor of the students who submitted it. I hope you will take into consideration that this is their first ever contribution to a project on Github and they’re still learning both the technical and collaborative aspects of the process. Given the timing in the semester, they may not be able to address these issues quickly. If it’s feasible for you to make the small adjustments, that might be the most efficient way to move things forward. Otherwise, I’m happy to create a new branch and submit an updated PR myself. Please let me know what works best for you. |
Hi @jmf-nyu, yep I hear you on the fact that these students are new to this, and we keep that in mind when reviewing - perfection is not a requirement 😀 However, communication + the work being in a mergeable state is. The student who made this submission did not acknowledge neither my nor Reto’s review comments back in December, and has not commented subsequently. In open source, as in life, we need communication in order to move things along. The submitter participating in this feedback loop is an essential part of the OS contribution process. Going forward, here is what would work best for us:
Maintaining this project is something that we do for free, for community benefit, and we ask that contributors respect our time. |
|
Hello! I want to say first that I am very very sorry for responding so late to this edit request. This past year between school and some personal life events, I have not been diligent in keeping up with projects outside of my immediate purview. That being said, with the end of the school year, I am more than happy to complete the requests you made this week. Again, I am incredibly sorry for such a late response. |
|
I have edited the code based on your feedback and sent in a pull request. Thank you! |
|
See #494 |
4 participants
Checklist
This pull request includes additions to the ImageMagick section of ffmprovisr.