Skip to content

Commit 98e8a52

Browse files
committed
fix(CardShape): update rotate function parameter type to readonly and simplify draw function
1 parent c2c5161 commit 98e8a52

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/templates/threejs/CardShape.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ type ShapeKey = keyof typeof SHAPES
5959
export const SHAPE_KEYS: ShapeKey[] = ['cube', 'octahedron', 'tetrahedron', 'diamond', 'prism', 'star']
6060

6161
// Rotate a point around X then Y axis
62-
function rotate(v: number[], rx: number, ry: number): [number, number, number] {
62+
function rotate(v: readonly number[], rx: number, ry: number): [number, number, number] {
6363
let [x, y, z] = v
6464
// Rotate Y
6565
const x1 = x * Math.cos(ry) - z * Math.sin(ry)
@@ -108,7 +108,7 @@ export default function CardShape({ index, color, size = 80, isHovered = false }
108108
let ry = 0
109109
let frameId: number
110110

111-
const draw = (ts: number) => {
111+
const draw = () => {
112112
frameId = requestAnimationFrame(draw)
113113
const speed = isHovRef.current ? 0.022 : 0.007
114114

0 commit comments

Comments
 (0)