fix(@angular/cli): correct linting errors in mcp tools

Author: amishne

packages/angular/cli/src/commands/mcp/mcp-server.ts

@@ -11,12 +11,12 @@ import { readFile } from 'node:fs/promises';
 import path from 'node:path';
 import type { AngularWorkspace } from '../../utilities/config';
 import { VERSION } from '../../utilities/version';
+import { registerInstructionsResource } from './resources/instructions';
 import { registerBestPracticesTool } from './tools/best-practices';
 import { registerDocSearchTool } from './tools/doc-search';
 import { registerFindExampleTool } from './tools/examples';
-import { registerListProjectsTool } from './tools/projects';
-import { registerInstructionsResource } from './resources/instructions';
 import { registerModernizeTool } from './tools/modernize';
+import { registerListProjectsTool } from './tools/projects';
 
 export async function createMcpServer(
   context: {

packages/angular/cli/src/commands/mcp/resources/instructions.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { readFile } from 'node:fs/promises';
 import path from 'node:path';

packages/angular/cli/src/commands/mcp/tools/modernize.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
 
@@ -52,13 +60,15 @@ const TRANSFORMATIONS: Array<Transformation> = [
   {
     name: 'standalone',
     description:
-      'Converts the application to use standalone components, directives, and pipes. This is a three-step process. After each step, you should verify that your application builds and runs correctly.',
-    instructions: `This migration requires running a cli schematic multiple times. Run the commands in the order listed below, verifying that your code builds and runs between each step:
-
-1. Run \`ng g @angular/core:standalone\` and select "Convert all components, directives and pipes to standalone"
-2. Run \`ng g @angular/core:standalone\` and select "Remove unnecessary NgModule classes"
-3. Run \`ng g @angular/core:standalone\` and select "Bootstrap the project using standalone APIs"
-`,
+      'Converts the application to use standalone components, directives, and pipes. This is a ' +
+      'three-step process. After each step, you should verify that your application builds and ' +
+      'runs correctly.',
+    instructions:
+      'This migration requires running a cli schematic multiple times. Run the commands in the ' +
+      'order listed below, verifying that your code builds and runs between each step:\n\n' +
+      '1. Run `ng g @angular/core:standalone` and select "Convert all components, directives and pipes to standalone"\n' +
+      '2. Run `ng g @angular/core:standalone` and select "Remove unnecessary NgModule classes"\n' +
+      '3. Run `ng g @angular/core:standalone` and select "Bootstrap the project using standalone APIs"',
     documentationUrl: 'https://angular.dev/reference/migrations/standalone',
   },
   {
@@ -81,8 +91,10 @@ export async function runModernization(input: ModernizeInput) {
   try {
     if (!input.transformations || input.transformations.length === 0) {
       const instructions = [
-        'See https://angular.dev/best-practices for Angular best practices. You can call this tool if you have specific transformation you want to run.',
+        'See https://angular.dev/best-practices for Angular best practices. ' +
+          'You can call this tool if you have specific transformation you want to run.',
       ];
+
       return {
         content: [
           {
@@ -99,7 +111,7 @@ export async function runModernization(input: ModernizeInput) {
     }
 
     const transformationsToRun = TRANSFORMATIONS.filter((t) =>
-      input.transformations!.includes(t.name),
+      input.transformations?.includes(t.name),
     );
 
     const allInstructions: string[] = [];
@@ -129,6 +141,7 @@ export async function runModernization(input: ModernizeInput) {
     };
   } catch (e) {
     const message = e instanceof Error ? e.message : 'An unknown error occurred.';
+
     return {
       content: [
         {
@@ -149,12 +162,16 @@ export function registerModernizeTool(server: McpServer): void {
       title: 'Modernize Angular Code',
       description:
         '<Purpose>\n' +
-        'This tool modernizes Angular code by applying the latest best practices and syntax improvements, ensuring it is idiomatic, readable, and maintainable.\n\n' +
+        'This tool modernizes Angular code by applying the latest best practices and syntax improvements, ' +
+        'ensuring it is idiomatic, readable, and maintainable.\n\n' +
         '</Purpose>\n' +
         '<Use Cases>\n' +
-        '* After generating new code: Run this tool immediately after creating new Angular components, directives, or services to ensure they adhere to modern standards.\n' +
-        '* On existing code: Apply to existing TypeScript files (.ts) and Angular templates (.ng.html) to update them with the latest features, such as the new built-in control flow syntax.\n\n' +
-        '* When the user asks for a specific transformation: When the transformation list is populated, these specific ones will be ran on the inputs.\n' +
+        '* After generating new code: Run this tool immediately after creating new Angular components, directives, ' +
+        'or services to ensure they adhere to modern standards.\n' +
+        '* On existing code: Apply to existing TypeScript files (.ts) and Angular templates (.ng.html) to update ' +
+        'them with the latest features, such as the new built-in control flow syntax.\n\n' +
+        '* When the user asks for a specific transformation: When the transformation list is populated, ' +
+        'these specific ones will be ran on the inputs.\n' +
         '</Use Cases>\n' +
         '<Transformations>\n' +
         TRANSFORMATIONS.map((t) => `* ${t.name}: ${t.description}`).join('\n') +
@@ -170,6 +187,6 @@ export function registerModernizeTool(server: McpServer): void {
           .describe('A list of instructions on how to run the migrations.'),
       },
     },
-    (input) => runModernization(input as ModernizeInput),
+    (input) => runModernization(input),
   );
 }

packages/angular/cli/src/commands/mcp/tools/modernize_spec.ts

@@ -1,12 +1,23 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
 import { ModernizeInput, runModernization } from './modernize';
 
 describe('Modernize Tool', () => {
   async function getInstructions(input: ModernizeInput): Promise<string[] | undefined> {
     const { structuredContent } = await runModernization(input);
+
     if (!structuredContent || !('instructions' in structuredContent)) {
       fail('Expected instructions to be present in the result');
+
       return;
     }
+
     return structuredContent.instructions;
   }
 
@@ -16,8 +27,9 @@ describe('Modernize Tool', () => {
     });
 
     expect(instructions).toEqual([
-      'To run the self-closing-tags-migration migration, execute the following command: `ng generate @angular/core:self-closing-tags-migration`.' +
-        '\nFor more information, see https://angular.dev/reference/migrations/self-closing-tags.',
+      'To run the self-closing-tags-migration migration, execute the following command: ' +
+        '`ng generate @angular/core:self-closing-tags-migration`.\nFor more information, ' +
+        'see https://angular.dev/reference/migrations/self-closing-tags.',
     ]);
   });
 
@@ -27,10 +39,12 @@ describe('Modernize Tool', () => {
     });
 
     const expectedInstructions = [
-      'To run the self-closing-tags-migration migration, execute the following command: `ng generate @angular/core:self-closing-tags-migration`.' +
-        '\nFor more information, see https://angular.dev/reference/migrations/self-closing-tags.',
-      'To run the test-bed-get migration, execute the following command: `ng generate @angular/core:test-bed-get`.' +
-        '\nFor more information, see https://angular.dev/guide/testing/dependency-injection.',
+      'To run the self-closing-tags-migration migration, execute the following command: ' +
+        '`ng generate @angular/core:self-closing-tags-migration`.\nFor more information, ' +
+        'see https://angular.dev/reference/migrations/self-closing-tags.',
+      'To run the test-bed-get migration, execute the following command: ' +
+        '`ng generate @angular/core:test-bed-get`.\nFor more information, ' +
+        'see https://angular.dev/guide/testing/dependency-injection.',
     ];
 
     expect(instructions?.sort()).toEqual(expectedInstructions.sort());
@@ -42,7 +56,8 @@ describe('Modernize Tool', () => {
     });
 
     expect(instructions).toEqual([
-      'See https://angular.dev/best-practices for Angular best practices. You can call this tool if you have specific transformation you want to run.',
+      'See https://angular.dev/best-practices for Angular best practices. You can call this ' +
+        'tool if you have specific transformation you want to run.',
     ]);
   });
 
@@ -51,7 +66,7 @@ describe('Modernize Tool', () => {
       transformations: ['standalone'],
     });
 
-    expect(instructions![0]).toContain(
+    expect(instructions?.[0]).toContain(
       'Run the commands in the order listed below, verifying that your code builds and runs between each step:',
     );
   });