refactor(@angular/cli): Revise how the schematics runner is invoked

Author: amishne

packages/angular/cli/BUILD.bazel

@@ -130,6 +130,7 @@ ts_project(
         "//:node_modules/@types/yargs",
         "//:node_modules/rxjs",
         "//:node_modules/semver",
+        "//:node_modules/typescript",
         "//packages/angular_devkit/schematics/testing",
     ],
 )

packages/angular/cli/src/commands/mcp/tools/modernize.ts

@@ -7,8 +7,6 @@ import { NodeWorkflow } from '@angular-devkit/schematics/tools';
 import { NodeJsSyncHost } from '@angular-devkit/core/node';
 import { virtualFs } from '@angular-devkit/core';
 
-export const SCHEMATICS_ROOT = '../../../../../../@angular/core/schematics';
-
 enum SchematicTarget {
   Code,
   Template,
@@ -155,9 +153,10 @@ export async function runModernization(
       },
     );
 
+    const angularCorePath = path.dirname(require.resolve('@angular/core/package.json'));
     const collectionPaths = {
-      [SchematicRunner.Migration]: path.join(__dirname, SCHEMATICS_ROOT, 'migrations.json'),
-      [SchematicRunner.Collection]: path.join(__dirname, SCHEMATICS_ROOT, 'collection.json'),
+      [SchematicRunner.Migration]: path.join(angularCorePath, 'schematics/migrations.json'),
+      [SchematicRunner.Collection]: path.join(angularCorePath, 'schematics/collection.json'),
     };
 
     const transformationsToRun =
@@ -178,7 +177,7 @@ export async function runModernization(
         documentation.add(transformation.documentation);
       }
 
-      let options: { [key: string]: unknown } = { path: tempDir };
+      let options: { [key: string]: unknown } = { path: '/' };
       if (transformation.name === 'standalone') {
         const mode = input.mode ?? 'convert-to-standalone';
         options = { ...options, mode };

packages/angular/cli/src/commands/mcp/tools/modernize_spec.ts

@@ -146,4 +146,53 @@ describe('Modernize Tool', () => {
       expect(fileResult?.content).toBe('<app-foo />');
     });
   });
+
+  describe('Integration Tests', () => {
+    let tempDir: string;
+
+    beforeEach(() => {
+      tempDir = fs.mkdtempSync(path.join(tmpdir(), 'modernize-spec-integration-'));
+      fs.mkdirSync(path.join(tempDir, 'node_modules'));
+      fs.symlinkSync(
+        path.resolve('node_modules/@angular-devkit'),
+        path.join(tempDir, 'node_modules/@angular-devkit'),
+        'dir',
+      );
+      fs.symlinkSync(
+        path.resolve('node_modules/typescript'),
+        path.join(tempDir, 'node_modules/typescript'),
+        'dir',
+      );
+    });
+
+    afterEach(() => {
+      fs.rmSync(tempDir, { recursive: true, force: true });
+    });
+
+    it('should run the self-closing-tags migration', async () => {
+      const runfilesRoot = path.join(__dirname, '../../../../../../../../');
+      const outputFile = path.join(runfilesRoot, 'runfiles.log');
+      console.log('Output file:', outputFile);
+      fs.writeFileSync(outputFile, '');
+      fs.readdirSync(runfilesRoot, { recursive: true }).forEach((file) => {
+        fs.appendFileSync(outputFile, file + '\n');
+      });
+
+      const input: ModernizeInput = {
+        files: [{ name: 'test.ng.html', content: '<app-foo></app-foo>' }],
+        transformations: ['self-closing-tags-migration'],
+      };
+
+      const result = await runModernization(input, undefined, tempDir);
+
+      if (!('files' in result.structuredContent) || !result.structuredContent.files) {
+        fail('Expected files to be present in the result');
+        return;
+      }
+
+      const fileResult = result.structuredContent.files[0];
+      expect(fileResult?.changed).toBe(true);
+      expect(fileResult?.content).toBe('<app-foo />');
+    });
+  });
 });