Open
Conversation
"echo 'Hello'" is a nasty nested string that causes undefined behavior with vim.fn.shellescape. Much better to use "pwd"! Oh, and I added an extra line of debug information to get the raw ssh command executed.
Owner
|
Thanks for raising this PR! Before we work on this further, I would like to discuss (in #157) and probably try to understand why an The reason for choosing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteStartproducing the following error:I added an extra line of debug information to get the raw ssh command executed:
The error is produced because "echo 'Hello'" is a nasty nested string that causes undefined behavior even with vim.fn.shellescape. Perhaps it's better to use "pwd"?