Fix pty for handling devpod provider setup#204
Open
johannes-graner wants to merge 1 commit intoamitds1997:mainfrom
Open
Fix pty for handling devpod provider setup#204johannes-graner wants to merge 1 commit intoamitds1997:mainfrom
johannes-graner wants to merge 1 commit intoamitds1997:mainfrom
Conversation
|
I have no comments on quality or anything of the sort, but this did fix the issue for me. Thank you. |
|
I can confirm this fix works for me! Please merge :) |
|
who needs to review this? |
|
Also blocking on the fix, would really appreciate prioritizing the merge or providing alternative workaround |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of this comment: #182 (comment), adding
ptyas an argument to the provider executor and passingpty = falsewhen handling the provider setup for devpod.I was unfortunately not able to set up all pre-commit hooks, so the
selenehook has not been run against this PR.This should fix #182.