Skip to content
This repository was archived by the owner on Nov 21, 2024. It is now read-only.

Commit f52e0bc

Browse files
Remove typos and printouts
1 parent 12e674f commit f52e0bc

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ feel free to fork and modify.
1212
If you only want to use AMIV API, check out the online documentation
1313
(There's a link in the github description above).
1414

15-
If you are an administrator and wish to get the AMIV API r`unning, keep reading!
15+
If you are an administrator and wish to get the AMIV API running, keep reading!
1616

1717
If you are a developer looking to work on AMIV API, it's best to look at the
1818
code directly. You can start with [bootstrap.py](amivapi/bootstrap.py),
@@ -36,7 +36,7 @@ You only need to install Docker, nothing else is required.
3636

3737
### Manual Installation for Development
3838

39-
For development, we recommend to **fork** the repository and install AMIV API
39+
For development, we recommend to fork the repository and install AMIV API
4040
manually.
4141

4242
First of all, we advise using a [virtual environment](https://docs.python.org/3/tutorial/venv.html).
@@ -76,7 +76,7 @@ password `amivapi`.
7676
docker swarm init
7777

7878
# Create a network so that the api service can later be connected to the db
79-
docker network create --driver overlay backend # Overlay so that it is representative of the real-life AMIV structure
79+
docker network create --driver overlay backend
8080

8181
#
8282
docker service create \
@@ -176,7 +176,7 @@ docker service create \
176176
amiveth/amivapi amivapi cron --continuous
177177

178178
# To attach your command line to the docker instance, use
179-
docker attach amivapi{...} # Use tab completion to find the name of the service
179+
docker attach amivapi... # Use tab completion to find the name of the service
180180

181181
# As we run docker as a service, it restarts by itself even if you use docker kill
182182
# To stop the service, use

amivapi/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
# SMTP server defaults
6969
API_MAIL = 'api@amiv.ethz.ch'
7070
API_MAIL_SUBJECT = "[AMIV] {subject}"
71-
SMTP_HOST = 'localhost' # None
71+
SMTP_HOST = 'localhost' # None in case you want to accept that no mails get sent (local testing)
7272
SMTP_PORT = 587
7373
SMTP_TIMEOUT = 10
7474

amivapi/utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ def mail(to, subject, text):
9696
'receivers': to,
9797
'text': text
9898
})
99-
elif app.config.get('DEBUG', False):
100-
print('{}{}{}{}'.format(subject, sender, to, text))
10199
elif config.SMTP_SERVER and config.SMTP_PORT:
102100
msg = MIMEText(text)
103101
msg['Subject'] = subject

0 commit comments

Comments
 (0)