Updates raxml to allow for floating point site weights#113
Open
computations wants to merge 4 commits into
Open
Updates raxml to allow for floating point site weights#113computations wants to merge 4 commits into
computations wants to merge 4 commits into
Conversation
We erroniously converted the site weights to ints, even though they could be floats. This means that any sites with a weight less than 1 was trimmed. This change simply updates the type in the lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the changes required for the lasso regression ML thing. Everything should be working, but here is what I have verified:
--all) completes without errorI think this should be sufficient for the researchers in Israel to finish their work, but please let me know if more is required.
A quick note about the
FloatWeightVector. I decided that this was needed for 2 reasons:WeightVectorwas used in contexts were using floats was inappropriate.But I can understand if you want only one
WeightVectortype. If this is the case, I will compact them into a single type by migrating the oldWeightVectorsto something likestd::vector<uintType>