Use str_increment() to fix PHP 8.5 deprecation (#456)

Also updates the GitHub action versions to fix the build.

Co-authored-by: Niklas Keller <me@kelunik.com>
Co-authored-by: Bob Weinand <bobwei9@hotmail.com>

Author: 3 people

.github/workflows/ci.yml

@@ -41,7 +41,7 @@ jobs:
           git config --global core.eol lf
 
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v5
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -53,7 +53,7 @@ jobs:
         run: echo "::set-output name=dir::$(composer config cache-dir)"
 
       - name: Cache dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: composer-${{ runner.os }}-${{ matrix.php-version }}-${{ hashFiles('**/composer.*') }}-${{ matrix.composer-flags }}

psalm.xml

@@ -18,6 +18,12 @@
             </errorLevel>
         </StringIncrement>
 
+        <UndefinedFunction>
+            <errorLevel type="suppress">
+                <referencedFunction name="str_increment"/>
+            </errorLevel>
+        </UndefinedFunction>
+
         <RedundantConditionGivenDocblockType>
             <errorLevel type="suppress">
                 <directory name="src" />

src/CompositeCancellation.php

@@ -69,7 +69,8 @@ public function __destruct()
 
     public function subscribe(\Closure $callback): string
     {
-        $id = $this->nextId++;
+        $id = $this->nextId;
+        \PHP_VERSION_ID >= 80300 ? $this->nextId = \str_increment($this->nextId) : ++$this->nextId;
 
         if ($this->exception) {
             EventLoop::queue($callback, $this->exception);

src/Internal/Cancellable.php

@@ -58,7 +58,8 @@ private function getException(): CancelledException
 
     public function subscribe(\Closure $callback): string
     {
-        $id = $this->nextId++;
+        $id = $this->nextId;
+        \PHP_VERSION_ID >= 80300 ? $this->nextId = \str_increment($this->nextId) : ++$this->nextId;
 
         if ($this->requested) {
             $exception = $this->getException();

src/Internal/FutureState.php

@@ -67,7 +67,8 @@ public function __destruct()
      */
     public function subscribe(\Closure $callback): string
     {
-        $id = self::$nextId++;
+        $id = self::$nextId;
+        \PHP_VERSION_ID >= 80300 ? self::$nextId = \str_increment(self::$nextId) : ++self::$nextId;
 
         $this->handled = true; // Even if unsubscribed later, consider the future handled.