Fix parsing of class names like 'w-1/3' as used in selectors like '.w-1\/3' - #4610
Merged
Conversation
westonruter
marked this pull request as ready for review
April 20, 2020 21:02
Member
Author
|
Build for testing: amp.zip (v1.5.4-alpha-20200420T213813Z-70cee0e15) |
schlessera
approved these changes
Apr 21, 2020
| diff --git a/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php b/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php | ||
| index e18f5d8..26c2e12 100644 | ||
| --- a/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php | ||
| +++ b/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php |
Collaborator
There was a problem hiding this comment.
Note that SabberWorm PHP CSS Parser seems to use PSR-2/PSR-12, not WPCS, so code style needs to be adapted if this is to be merged into the upstream package.
pierlon
approved these changes
Apr 21, 2020
pierlon
left a comment
pierlon
left a comment
Contributor
There was a problem hiding this comment.
Otherwise from @schlessera's note above, this looks good 👍 .
Member
Author
|
I'll keep this to the v1.6 release since updating the CSS parser could have big impacts. |
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master.patches/php-css-parser-138-extended.patch(introduced in Require unreleased version of PHP-CSS-Parser #4300) which was merged intomaster.Fixes #4609
Checklist