🐛 verify message source on cached sentinel in inabox host#40519
Open
rootvector2 wants to merge 1 commit into
Open
🐛 verify message source on cached sentinel in inabox host#40519rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFrameElement_caches the resolved ad frame under the messagesentineland, on later messages, returns it without re-checkingmessage.source, so a frame that reuses another inabox frame's sentinel resolves to that frame and gets its viewport/target geometry streamed back throughhandleSendPositions_(and can drive its overlay). Found while auditing the source-validation path, whose own doc comment says it checks the message source, but only the cache-miss branch actually does. Bind each cached sentinel to the source window that registered it and reject reuse from a different source.