Added .today() method#1090
Open
nxtpl wants to merge 2 commits into
Open
Conversation
Closed
Author
|
Hi, will it be integrated into the main version? |
Contributor
|
Hi @nxtpl, We are currently working on v5. You can already try an early v5 version. Can you check if it is missing there? If so please create a new PR, otherwise we can close this one as resolved. |
Contributor
|
Also please do not commit to your master branch and create a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR:
Added .today() method that resets calendar view to a current date;
Full story:
When using this plugin on a website with multiple calendars, there was a problem - when really old date was picked, the rest calendars remembered it. So it was needed to change the year and month manually. Of course, there is a TODAY button, but users expected a fresh new calendar and submitted forms with wrong dates.
The plugin missed the functionality to reset calendar view only (without removing picked date from input field). To avoid confusion, I named the method .today(), as it don't alter the date field.
Also, added a test case,.