Cleanup ic.molecular_cloud#1093
Merged
Merged
Conversation
rieder
commented
Nov 26, 2024
rieder
commented
Member
- Slightly better syntax
- More consistent keyword naming, with a warning for when the old style is used
- No more default number of particles, must be set explicitly
particles, not stars
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
status: stale
stale
Bot
removed
the
status: stale
Member
Author
|
Can be merged I think |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
status: stale
Member
Author
|
@LourensVeen could you approve this? I'd like it merged to have more consistency in the book examples. |
stale
Bot
removed
the
status: stale
Member
Author
|
@LourensVeen please approve if you have no objections :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.