Skip to content

Use standard __version__ variable for version#1232

Merged
LourensVeen merged 1 commit into
amusecode:mainfrom
LourensVeen:issue_1187_literature_version_missing
Mar 12, 2026
Merged

Use standard __version__ variable for version#1232
LourensVeen merged 1 commit into
amusecode:mainfrom
LourensVeen:issue_1187_literature_version_missing

Conversation

@LourensVeen

Copy link
Copy Markdown
Member

It turns out hatchling only writes __version__, so we'll have to make do without the non-standard version. This updates the literature subsystem to import and use that so that we get correct versions again.

I've also removed the catch, which will cause AMUSE to crash if the version isn't found in the future. That should never happen on a correct install (including a development install, because pip install -e will create _version.py also in that case. If it does happen, then we want to know and fix it, not silently ignore the problem.

Fixes #1187.

@LourensVeen LourensVeen requested a review from a team as a code owner March 12, 2026 12:58
@LourensVeen LourensVeen merged commit ddc5dcd into amusecode:main Mar 12, 2026
3 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Development Board Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Literature list fails to get version of AMUSE

1 participant