Skip to content

Commit 665debe

Browse files
committed
Treat missing or non-GitHub source as a neutral skip
1 parent 7219b06 commit 665debe

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

ci/pr-check/src/main.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -340,20 +340,18 @@ async fn check_tool(client: &GithubClient, tool: &ParsedEntry) -> Result<ToolRep
340340
note: None,
341341
})
342342
} else {
343-
// Not a GitHub repo or no source field.
344-
let note = if source.is_none() {
345-
"No source URL provided. Please add a `source` field pointing to the repository.".into()
346-
} else {
347-
"Source is not a GitHub repository. Stars, contributor count, and age cannot be checked automatically. Please verify these manually against the contributing criteria.".into()
348-
};
343+
// No source or non-GitHub source. This is fine for proprietary or
344+
// hosted tools. Skip automated checks and leave a note for manual review.
345+
let note = "No GitHub source URL found. Automated checks for stars, contributor count, \
346+
and age are not possible. Please verify the contributing criteria manually.";
349347

350348
Ok(ToolReport {
351349
name: tool.name.to_string(),
352350
source,
353-
stars: CheckResult::Skip("N/A (non-GitHub source)".into()),
354-
contributors: CheckResult::Skip("N/A (non-GitHub source)".into()),
355-
age: CheckResult::Skip("N/A (non-GitHub source)".into()),
356-
note: Some(note),
351+
stars: CheckResult::Skip("N/A".into()),
352+
contributors: CheckResult::Skip("N/A".into()),
353+
age: CheckResult::Skip("N/A".into()),
354+
note: Some(note.into()),
357355
})
358356
}
359357
}

0 commit comments

Comments
 (0)