Skip to content

Avoid checksum generation when not desired to circumvent FIPS problems #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anancarv merged 4 commits into from
Sep 11, 2025
Merged

Avoid checksum generation when not desired to circumvent FIPS problems #222

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c170b00
Avoid checksum generation when not desired
tommycbird Aug 26, 2025
ac23195
Revert "Avoid checksum generation when not desired"
tommycbird Sep 10, 2025
ab37ba5
Updated mapping to pass in usedforsecurity=False
tommycbird Sep 10, 2025
20c6d38
try catch for security flag, unit tests added
tommycbird Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyartifactory/models/artifact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ class Checksums(BaseModel):
@classmethod
def generate(cls, file_: Path) -> Checksums:
block_size: int = 65536
mapping: dict[str, Callable[[], Any]] = {"md5": hashlib.md5, "sha1": hashlib.sha1, "sha256": hashlib.sha256}
mapping: dict[str, Callable[[], Any]] = {
"md5": lambda: hashlib.md5(usedforsecurity=False),
Comment thread
tommycbird marked this conversation as resolved.
Outdated
"sha1": lambda: hashlib.sha1(usedforsecurity=False),
"sha256": lambda: hashlib.sha256(usedforsecurity=False),
}
results = {}

for algorithm, hashing_function in mapping.items():
Expand Down
Loading