named and default args for struct constructors#1
Open
anandrav wants to merge 2 commits into
Open
Conversation
Reuses the existing FuncArgDetails / function_call_arg_order machinery by adding a Struct variant to FuncArgDetailsKey and generalizing update_function_arg_info via a new iter_args() method on the key. Struct field defaults are name-resolved and type-checked at the type definition, and reordered into positional form at each call site.
Cleans up the four positive struct named/default arg tests so the assertion calls Greeter(...).greet() instead of inlining the field-concatenation, and mirrors the same pattern in the user-guide example.
anandrav
force-pushed
the
claude/explain-cloud-environments-MaInQ
branch
from
4b505ca to
5caae18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses the existing FuncArgDetails / function_call_arg_order machinery by
adding a Struct variant to FuncArgDetailsKey and generalizing
update_function_arg_info via a new iter_args() method on the key. Struct
field defaults are name-resolved and type-checked at the type definition,
and reordered into positional form at each call site.