fix(binary): support s390x go binary versions 1.8.x and 1.9.x#4900
Open
tjhub1983 wants to merge 2 commits into
Open
fix(binary): support s390x go binary versions 1.8.x and 1.9.x#4900tjhub1983 wants to merge 2 commits into
tjhub1983 wants to merge 2 commits into
Conversation
Fixes anchore#4866 Signed-off-by: tjhub1983 <tjhub1983@users.noreply.github.com>
Contributor
|
This does not have proper DCO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4866.
Problem: The
go-binaryclassifier fails to detect version for go 1.8.x and 1.9.x on s390x architecture. Thego1.8.7version string is stored as a null-terminated string�go1.8.7�in s390x binaries, which the existing patterns don't match.Before:
syft --platform linux/s390x golang:1.8.7showsgo 1.1(wrong version)After:
syft --platform linux/s390x golang:1.8.7showsgo@1.8.7Fix: Added a third
SupportingEvidenceMatcherwith pattern�go(?P<version>[0-9]+\.[0-9]+\.[0-9]+)that specifically targets the null-terminated s390x version string format.Changes
syft/pkg/cataloger/binary/classifiers.go: Added s390x-specific null-terminated version matcher for go binarysyft/pkg/cataloger/binary/classifier_cataloger_test.go: Added test case for s390x go binarysyft/pkg/cataloger/binary/testdata/classifiers/snippets/go-version-hint/1.8.7/s390x/go: Added test fixtureTest
```bash
$ syft -q --platform linux/s390x golang:1.8.7 | grep "go "
go 1.8.7 binary
```
This PR is a recreation of #4884 with proper DCO sign-off on all commits.