fix: pass onOpen to FlagButton and extend DE phone mask#15
Open
ehernandezlabelgrup wants to merge 1 commit intoanday013:mainfrom
Open
fix: pass onOpen to FlagButton and extend DE phone mask#15ehernandezlabelgrup wants to merge 1 commit intoanday013:mainfrom
ehernandezlabelgrup wants to merge 1 commit intoanday013:mainfrom
Conversation
- renderFlagButton was ignoring the props passed by CountryPicker, which include onOpen. This caused tapping the flag emoji to do nothing because FlagButton's internal TouchableOpacity had no onPress handler. Now onOpen is forwarded so tapping the flag opens the country modal. - The German (DE) mask only allowed 6 digits, blocking mobile numbers like +49 176 96079449 (11 digits). Updated mask to support up to 11-digit numbers (XXXX XXXXXXX format). Closes anday013#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderFlagButton was ignoring the props passed by CountryPicker, which include onOpen. This caused tapping the flag emoji to do nothing because FlagButton's internal TouchableOpacity had no onPress handler. Now onOpen is forwarded so tapping the flag opens the country modal.
The German (DE) mask only allowed 6 digits, blocking mobile numbers like +49 176 96079449 (11 digits). Updated mask to support up to 11-digit numbers (XXXX XXXXXXX format).
Closes #9