Drop unrolled annotation as its not affecting performance

Author: andersfugmann

bench/bench.ml

@@ -225,7 +225,11 @@ let _ =
       List.init 1000 ~f:(fun i -> i+1, i * i+1) |> make_tests "map<int64,int64>" (module Protoc.Map) (module Plugin.Map);
 
       (* random_list ~len:100 ~f:(fun () -> Plugin.Enum_list.Enum.ED) () |> make_tests (module Protoc.Enum_list) (module Plugin.Enum_list); *)
-    ] @ make_int_tests (0xFFFF_FFFFL) @ make_int_tests (0xFFFF_FFFF_FFFF_FFFFL)
+    ]
+    @ make_int_tests (0x1L)
+    @ make_int_tests (0xFFFFL)
+    @ make_int_tests (0xFFFF_FFFFL)
+    @ make_int_tests (0xFFFF_FFFF_FFFF_FFFFL)
   in
   printf "|          Name               |   plugin   |   protoc   | ratio |\n";
   printf "|           --                |     --     |     --     |  --   |\n";

src/ocaml_protoc_plugin/reader.ml

@@ -36,6 +36,8 @@ let[@inline] read_byte t =
     v
   | false -> Result.raise `Premature_end_of_input
 
+(* TODO: Speedup by inlining read_byte by copying out offset and end_offset out of the t structure so the inner loop does not have any side-effects. The copy back the offset to t once done. *)
+
 let read_varint t =
   let open Infix.Int64 in
   let rec inner acc bit =
@@ -46,7 +48,7 @@ let read_varint t =
       inner acc (Int.add bit 7)
     | false -> acc
   in
-  (inner[@unrolled 10]) 0L 0
+  inner 0L 0
 
 let read_varint_unboxed t = read_varint t |> Int64.to_int
 

src/ocaml_protoc_plugin/writer.ml

@@ -38,7 +38,7 @@ let write_varint buffer ~offset v =
       Bytes.unsafe_set buffer offset ((v land 0x7fL) lor 0b1000_0000L |> Int64.to_int |> Char.unsafe_chr);
       inner ~offset:next_offset rem
   in
-  (inner[@unrolled 10]) ~offset v
+  inner ~offset v
 
 let write_varint_unboxed buffer ~offset v = write_varint buffer ~offset (Int64.of_int v)