feat(elements): make ElementDeclaration fields nullable#1
Merged
Conversation
Optional opt-in via field presence — declaring a field is enough. Drops `HasImage`/`HasShadow`/`HasBorder`/`HasCustomData`/`IsFloating`/ `IsScrollable` sentinel checks in ConfigureOpenElement; checks for `is not null` instead. Layout falls back to default when null. Id stays required. ClayUI widgets that previously assigned `Shadow = s.Shadow` / `Border = s.Border` unconditionally now guard with `HasShadow` / `HasBorder` so empty styles map to null. Avoids spurious Shadow render commands (the renderer emits unconditionally on config presence) and saves storage for empty Border configs. Adds OptionalElementDeclarationTests (23 cases) covering null-by- default, declaration-is-enough (empty Custom/Shadow/Scroll), and regression for factory methods + existing styled paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional opt-in via field presence — declaring a field is enough. Drops
HasImage/HasShadow/HasBorder/HasCustomData/IsFloating/IsScrollablesentinel checks in ConfigureOpenElement; checks foris not nullinstead. Layout falls back to default when null. Id stays required.ClayUI widgets that previously assigned
Shadow = s.Shadow/Border = s.Borderunconditionally now guard withHasShadow/HasBorderso empty styles map to null. Avoids spurious Shadow render commands (the renderer emits unconditionally on config presence) and saves storage for empty Border configs.Adds OptionalElementDeclarationTests (23 cases) covering null-by- default, declaration-is-enough (empty Custom/Shadow/Scroll), and regression for factory methods + existing styled paths.