Skip to content

[BUG] dry-run don't return error code when changes are found in xlf files #427

Description

@wtfred

Minimal PHP Code Causing Issue

I'm running fractor through composer scripts.
It allow me to use it on my CI, on every push, along with rector, phpstan and such

I'm using something in that flavor

"check:fractor": [
    "@composer -d $(pwd)/.tools/fractor exec -- vendor/bin/fractor process -c $(pwd)/fractor.php --dry-run"
],

When fractor needs to make changes in a typoscript file, it return error code 2

...
[OK] 1 files would have been changed (dry-run) by Fractor                                                                                                                 

Script vendor/bin/fractor handling the __exec_command event returned with error code 2
Script @composer -d $(pwd)/.tools/fractor exec -- vendor/bin/fractor process -c $(pwd)/fractor.php --dry-run handling the check:fractor event returned with error code 2

But now with 1.0, when changes needs to be made in xlf files, it does not return error code, so it doesn't stop the cli execution, and so it doesn't stop the CI pipeline aswell.
(It still stops if changes are to be made on other files, like with typoscript for example)

[OK] 8 files would have been changed (dry-run) by Fractor

Applied rules

Typo3LevelSetList::UP_TO_TYPO3_14

Expected Behaviour

I would expect the dry-run to through an error code like it does with other files types.

Package Version

1.0.0

PHP Version

8.4.22

TYPO3 Version

14.3.4

Notes

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions