Skip to content

Commit ed48042

Browse files
Merge pull request #98 from breyed/patch-2
Document HttpClient isolation
2 parents 0f71b0d + f04608b commit ed48042

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

CorePush/Apple/ApnSender.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public class ApnSender : IApnSender
3636
private readonly HttpClient http;
3737
private readonly IJsonSerializer serializer;
3838

39+
/// <param name="http">A <see cref="HttpClient"/> dedicated to this <see cref="ApnSender"/>. Do not use a shared <see cref="HttpClient"/> instance, since its instance-level state may be modified. However, its <see cref="HttpClientHandler" can be shared.</param>
3940
public ApnSender(ApnSettings settings, HttpClient http) : this(settings, http, new DefaultCorePushJsonSerializer())
4041
{
4142
}
@@ -154,4 +155,4 @@ private static string Base64UrlEncode(string str)
154155
}
155156

156157
private static string Base64UrlEncode(byte[] bytes) => Convert.ToBase64String(bytes);
157-
}
158+
}

0 commit comments

Comments
 (0)