Remove BouncyCastle, upgrade to .NET 10, fix bugs#102
Merged
andrei-m-code merged 2 commits intomasterfrom Mar 23, 2026
Merged
Conversation
- Replace BouncyCastle with built-in System.Security.Cryptography APIs - ApnSender: use ECDsa.ImportPkcs8PrivateKey for ECDSA signing - FirebaseSender: use RSA.ImportFromPem for RSA signing - Upgrade target framework to .NET 10 - Fix Base64URL encoding in both senders (RFC 7617) - Fix potential NullReferenceException in APN error handling - Fix static token cache key collision by including key ID - Add device token validation in ApnSender.SendAsync - Propagate CancellationToken in FirebaseSender - Update CI/CD workflows to .NET 10 - Remove infinite loop in CorePush.Tester - Remove unused System.IdentityModel.Tokens.Jwt dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BouncyCastle removal — replaced with built-in
System.Security.CryptographyAPIs:ApnSender: replaced BouncyCastlePrivateKeyFactory+ manual EC point multiplication withECDsa.ImportPkcs8PrivateKey()(available since .NET Core 3.0)FirebaseSender: replaced BouncyCastlePemReader+RsaDigestSignerwithRSA.ImportFromPem()+RSA.SignData()(available since .NET 5)Upgrade to .NET 10 — target framework and CI/CD workflows updated.
Bug fixes included:
ApnSenderandFirebaseSender— was using plain Base64 instead of URL-safe Base64 (RFC 7617), which could produce malformed JWTsNullReferenceExceptioninApnSendererror deserializationP8PrivateKeyIddeviceTokenvalidation inApnSender.SendAsync()CancellationTokenthroughFirebaseSender.GetJwtTokenAsync()CorePush.TesterSystem.IdentityModel.Tokens.Jwtdependency from testerTest plan