Adjust FilterUsers solution

Author: andrei-punko

src/main/java/by/andd3dfx/collections/FilterUsers.java

@@ -26,12 +26,11 @@ public class FilterUsers {
 
     public static List<String> apply(List<User> users) {
         return users.stream()
-            .filter(user -> !user.lastLogin
-                .plusDays(3)
-                .isBefore(LocalDate.now()))
+            .filter(user -> user.lastLogin.isAfter(LocalDate.now().minusDays(3)))
             .map(User::getName)
             .distinct()
-            .collect(Collectors.groupingBy(String::length)).entrySet().stream()
+            .collect(Collectors.groupingBy(String::length))
+            .entrySet().stream()
             .max(Comparator.comparingInt(Map.Entry::getKey))
             .map(Map.Entry::getValue)
             .orElseGet(List::of);

src/test/java/by/andd3dfx/collections/FilterUsersTest.java

@@ -13,16 +13,18 @@ public class FilterUsersTest {
     @Test
     public void apply() {
         List<User> users = List.of(
-            new User("Anton", LocalDate.now().minusDays(5)),
-            new User("Gena", LocalDate.now().minusDays(3)),
-            new User("John", LocalDate.now().minusDays(2)),
-            new User("Vladimir", LocalDate.now().minusDays(1)),
-            new User("Anatoliy", LocalDate.now().minusDays(3))
+            new User("Anton", LocalDate.now().minusDays(5)),    // not max chars amount, too old
+            new User("Gena", LocalDate.now().minusDays(3)),     // not max chars amount
+            new User("John", LocalDate.now().minusDays(2)),     // not max chars amount
+            new User("Anatoliy", LocalDate.now().minusDays(1)), // expected (max chars amount)
+            new User("Vladimir", LocalDate.now().minusDays(1)), // expected (max chars amount)
+            new User("Kirillus", LocalDate.now().minusDays(4)), // too old
+            new User("Anatoliy", LocalDate.now().minusDays(3))  // duplicate
         );
 
         var result = FilterUsers.apply(users);
 
-        assertThat(result).isEqualTo(List.of("Vladimir", "Anatoliy"));
+        assertThat(result).containsOnly("Vladimir", "Anatoliy");
     }
 
     @Test