Fix unicorn lint errors from eslint-plugin-unicorn v65

Add split() limits and use .includes() over repeated equality checks.

Author: andreogle

bun.lock

@@ -54,7 +54,7 @@ describe('S31 — SSE streaming', () => {
     expect(text).toContain('"done":true');
 
     // Parse the SSE event
-    const jsonStr = text.split('data: ')[1]?.split('\n')[0] ?? '';
+    const jsonStr = text.split('data: ', 2)[1]?.split('\n', 1)[0] ?? '';
     const event = JSON.parse(jsonStr) as { done: boolean; airnode: string; endpointId: string; signature: string };
 
     expect(event.done).toBe(true);
@@ -73,7 +73,7 @@ describe('S31 — SSE streaming', () => {
     });
 
     const text = await response.text();
-    const jsonStr = text.split('data: ')[1]?.split('\n')[0] ?? '';
+    const jsonStr = text.split('data: ', 2)[1]?.split('\n', 1)[0] ?? '';
     const event = JSON.parse(jsonStr) as { data: Hex; timestamp: number };
 
     // WeatherAPI currentTemp has encoding — data should be ABI-encoded

integration/scenarios/s31-sse-streaming.test.ts

@@ -38,7 +38,7 @@
     "eslint-plugin-functional": "^10.0.0",
     "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-promise": "^7.3.0",
-    "eslint-plugin-unicorn": "^64.0.0",
+    "eslint-plugin-unicorn": "^65.0.1",
     "prettier": "3.8.4",
     "prettier-plugin-solidity": "^2.3.1",
     "typescript-eslint": "^8.61.0"

package.json

@@ -87,7 +87,7 @@ function buildApiRequest(api: Api, endpoint: Endpoint, requestParameters: Record
     headers['Cookie'] = existing ? `${existing}; ${cookieString}` : cookieString; // eslint-disable-line functional/immutable-data
   }
 
-  const hasBody = endpoint.method === 'POST' || endpoint.method === 'PUT' || endpoint.method === 'PATCH';
+  const hasBody = ['POST', 'PUT', 'PATCH'].includes(endpoint.method);
   const body = hasBody && Object.keys(bodyParameters).length > 0 ? JSON.stringify(bodyParameters) : undefined;
 
   if (body && !headers['Content-Type']) {

src/api/call.ts

@@ -116,7 +116,7 @@ function castToUint256(raw: JsonValue, multiply: string | undefined): bigint {
 }
 
 function castToBool(raw: JsonValue): boolean {
-  return raw === true || raw === 'true' || raw === 1 || raw === '1';
+  return ([true, 'true', 1, '1'] as JsonValue[]).includes(raw);
 }
 
 function castToBytes32(raw: JsonValue): Hex {

src/api/process.ts

@@ -91,8 +91,8 @@ describe('text format', () => {
       logger.info('short');
     });
     const output = lastCall(infoMock);
-    const afterLevel = output.split(' INFO ')[1] ?? '';
-    const beforeMeta = afterLevel.split('requestId=')[0] ?? '';
+    const afterLevel = output.split(' INFO ', 2)[1] ?? '';
+    const beforeMeta = afterLevel.split('requestId=', 1)[0] ?? '';
     expect(beforeMeta.length).toBeGreaterThanOrEqual(80);
   });
 

src/logger.test.ts

@@ -86,7 +86,7 @@ function parseRequestRoute(pathname: string): string | undefined {
 // entry — the originating client — instead.
 function resolveClientIp(request: Request, peerAddress: string | undefined, trustForwardedFor: boolean): string {
   if (trustForwardedFor) {
-    const forwarded = request.headers.get('X-Forwarded-For')?.split(',')[0]?.trim();
+    const forwarded = request.headers.get('X-Forwarded-For')?.split(',', 1)[0]?.trim();
     if (forwarded) return forwarded;
   }
   return peerAddress ?? 'unknown';