chore: adopt eslint-plugin-unicorn v68 and resolve fallout

Bump eslint-plugin-unicorn 65 -> 68 (and viem 2.52 -> 2.53), then work
through the new rule violations.

Rules disabled (with rationale in eslint.config.mjs):
- name-replacements (preference)
- no-useless-recursion (conflicts with functional/no-loop-statements)
- prefer-else-if (conflicts with the no-else / early-return style)
- prefer-await (conflicts with no-try/catch and deliberate promise combinators)
- no-top-level-assignment-in-function, no-global-object-property-assignment,
  max-nested-calls (test files only)
- no-top-level-side-effects (cli command modules only)

Rules fixed in code:
- prefer-iterator-to-array, require-array-sort-compare, prefer-url-href,
  prefer-minimal-ternary, no-unsafe-string-replacement,
  no-computed-property-existence-check, no-declarations-before-early-exit,
  no-break-in-nested-loop, no-non-function-verb-prefix
- consistent-boolean-name renames: isWithinRateLimit, isConstantTimeEqual,
  hasAddressInRecords, isTruthy, shouldInterpolate, shouldTrustForwardedFor

Style:
- curly: 'multi-line' -> 'all' (braces required on all control flow)

Tests:
- Backfill coverage for branches the brace change exposed (server, process,
  json-path, pipeline, auth, plugins, async, proof). 509 -> 573 tests.

Author: andreogle

bun.lock

@@ -56,7 +56,7 @@ export default defineConfig([
       'no-else-return': ['error', { allowElseIf: false }],
 
       // --- General strict rules ---
-      curly: ['error', 'multi-line'],
+      curly: ['error', 'all'],
       eqeqeq: ['error', 'always'],
       'no-console': ['warn', { allow: ['info', 'warn', 'error'] }],
       'no-eval': 'error',
@@ -74,6 +74,14 @@ export default defineConfig([
 
       // --- Unicorn overrides ---
       'unicorn/prevent-abbreviations': 'off',
+      'unicorn/name-replacements': 'off',
+      // Conflicts with functional/no-loop-statements (recursion replaces loops).
+      'unicorn/no-useless-recursion': 'off',
+      // Conflicts with the no-else / early-return style (wants `else if`).
+      'unicorn/prefer-else-if': 'off',
+      // Conflicts with the no-try/catch convention and deliberate promise
+      // combinators used to cache and race promises.
+      'unicorn/prefer-await': 'off',
 
       // --- Import ordering (alphabetical) ---
       'import-x/order': [
@@ -93,6 +101,19 @@ export default defineConfig([
 
   {
     files: ['**/*.test.ts', '**/*.test.tsx'],
-    rules: Object.fromEntries(Object.keys(functionalPlugin.rules).map((rule) => [`functional/${rule}`, 'off'])),
+    rules: {
+      ...Object.fromEntries(Object.keys(functionalPlugin.rules).map((rule) => [`functional/${rule}`, 'off'])),
+      // Standard async fixture pattern: `let ctx; beforeAll(() => { ctx = ... })`.
+      'unicorn/no-top-level-assignment-in-function': 'off',
+      // Tests mock process globals (e.g. fetch) and nest calls in assertions.
+      'unicorn/no-global-object-property-assignment': 'off',
+      'unicorn/max-nested-calls': 'off',
+    },
+  },
+
+  {
+    // CLI command modules build commander.js commands at module load.
+    files: ['src/cli/**/*.ts'],
+    rules: { 'unicorn/no-top-level-side-effects': 'off' },
   },
 ]);

eslint.config.mjs

@@ -201,7 +201,9 @@ export default function encryptedChannel(config: Config): AirnodePlugin {
       // =======================================================================
       onBeforeApiCall: (ctx: BeforeApiCallContext): BeforeApiCallResult => {
         const encrypted = ctx.parameters['_encrypted'];
-        if (!encrypted) return;
+        if (!encrypted) {
+          return;
+        }
 
         const ciphertext = hexToBytes(encrypted);
         if (ciphertext.length < PUBKEY_LENGTH + NONCE_LENGTH + TAG_LENGTH) {
@@ -241,7 +243,9 @@ export default function encryptedChannel(config: Config): AirnodePlugin {
       // =======================================================================
       onBeforeSign: (ctx: BeforeSignContext): BeforeSignResult => {
         const responsePubKey = responseKeys.get(ctx.requestId);
-        if (!responsePubKey) return;
+        if (!responsePubKey) {
+          return;
+        }
 
         // Clean up stored key
         responseKeys.delete(ctx.requestId); // eslint-disable-line functional/immutable-data

examples/plugins/encrypted-channel.ts

@@ -68,7 +68,9 @@ export default function heartbeat(config: Config): AirnodePlugin {
     name: 'heartbeat',
     hooks: {
       onResponseSent: async (context: ResponseSentContext) => {
-        if (!config.url) return;
+        if (!config.url) {
+          return;
+        }
 
         const payload: HeartbeatPayload = {
           timestamp: new Date().toISOString(),
@@ -80,7 +82,7 @@ export default function heartbeat(config: Config): AirnodePlugin {
 
         const headers: Record<string, string> = {
           'Content-Type': 'application/json',
-          ...(config.apiKey ? { 'x-api-key': config.apiKey } : {}),
+          ...(config.apiKey && { 'x-api-key': config.apiKey }),
         };
 
         await fetch(config.url, {

examples/plugins/heartbeat.ts

@@ -111,10 +111,12 @@ async function createTestServer(options: TestServerOptions = {}): Promise<TestCo
 }
 
 function findEndpointId(endpointMap: ReadonlyMap<Hex, ResolvedEndpoint>, apiName: string, endpointName: string): Hex {
-  const entry = [...endpointMap.entries()].find(
+  const entry = [...endpointMap].find(
     ([, resolved]) => resolved.api.name === apiName && resolved.endpoint.name === endpointName
   );
-  if (!entry) throw new Error(`Endpoint ${apiName}/${endpointName} not found`);
+  if (!entry) {
+    throw new Error(`Endpoint ${apiName}/${endpointName} not found`);
+  }
   return entry[0];
 }
 
@@ -137,7 +139,9 @@ async function setMockResponse(path: string, response: unknown, status = 200): P
     headers: { 'Content-Type': 'application/json' },
     body: JSON.stringify({ path, response, status }),
   });
-  if (!result.ok) throw new Error(`Failed to set mock response: ${String(result.status)}`);
+  if (!result.ok) {
+    throw new Error(`Failed to set mock response: ${String(result.status)}`);
+  }
 }
 
 interface RecordedCall {
@@ -149,13 +153,17 @@ interface RecordedCall {
 
 async function getMockCalls(): Promise<readonly RecordedCall[]> {
   const response = await fetch(`${MOCK_API_URL}/mock/calls`);
-  if (!response.ok) throw new Error(`Failed to get mock calls: ${String(response.status)}`);
+  if (!response.ok) {
+    throw new Error(`Failed to get mock calls: ${String(response.status)}`);
+  }
   return (await response.json()) as RecordedCall[];
 }
 
 async function resetMock(): Promise<void> {
   const result = await fetch(`${MOCK_API_URL}/mock/reset`, { method: 'POST' });
-  if (!result.ok) throw new Error(`Failed to reset mock: ${String(result.status)}`);
+  if (!result.ok) {
+    throw new Error(`Failed to reset mock: ${String(result.status)}`);
+  }
 }
 
 export {

integration/helpers.ts

@@ -32,7 +32,9 @@ const DEFAULT_RESPONSES: Record<string, unknown> = {
 function findDefaultResponse(pathname: string): unknown {
   // eslint-disable-next-line functional/no-loop-statements
   for (const [prefix, response] of Object.entries(DEFAULT_RESPONSES)) {
-    if (pathname.startsWith(prefix)) return response;
+    if (pathname.startsWith(prefix)) {
+      return response;
+    }
   }
   return { mock: true };
 }

integration/mock-api.ts

@@ -15,7 +15,7 @@ console.info(`Mock API server at http://127.0.0.1:${String(mock.port)}`);
 // Run each test file in its own process
 // =============================================================================
 const glob = new Glob('integration/scenarios/s*.test.ts');
-const files = [...glob.scanSync('.')].toSorted();
+const files = [...glob.scanSync('.')].toSorted((a, b) => a.localeCompare(b));
 
 // eslint-disable-next-line functional/no-let
 let failed = 0;

integration/run-sequential.ts

@@ -10,7 +10,9 @@ beforeAll(async () => {
   ctx = await createTestServer({
     apiOverrides: (apis) =>
       apis.map((api) => {
-        if (api.name !== 'WeatherAPI') return api;
+        if (api.name !== 'WeatherAPI') {
+          return api;
+        }
         return {
           ...api,
           endpoints: api.endpoints.map((ep) => (ep.name === 'currentTemp' ? { ...ep, mode: 'stream' as const } : ep)),