chore: remove dead EXPIRY_HTLC constant from keys#178
Open
andrerfneves wants to merge 1 commit into
Open
Conversation
The EXPIRY_HTLC constant ('expiry_htlc') was defined, exported, and had a
switch case in formatDetailsKey, but this key never appears in any decoded
Lightning data output. BOLT11 tag code 24 correctly maps to
'min_final_cltv_expiry'.
Removing this dead constant reduces confusion for developers who might
otherwise look for 'expiry_htlc' in decoded invoice data.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead
EXPIRY_HTLCconstant ('expiry_htlc') fromsrc/constants/keys.js, along with its switch case insrc/utils/keys.jsand the corresponding test case inkeys.test.js.Why
The key
'expiry_htlc'never appears in any decoded Lightning data output:min_final_cltv_expiry, notexpiry_htlcThis constant was misleading — developers looking at the constants file might expect
expiry_htlcto appear in decoded invoices, but it never does.Changes
src/constants/keys.js: RemovedEXPIRY_HTLC = 'expiry_htlc'exportsrc/utils/keys.js: RemovedEXPIRY_HTLCimport and itscaseinformatDetailsKeysrc/utils/keys.test.js: Removed theexpiry_htlctest case fromformatDetailsKeytestsTest Plan