From 7107fb54d0e944d949157055ae1c4696e82c8fda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Neves?= <andrerfneves@users.noreply.github.com>
Date: Sat, 13 Jun 2026 18:05:10 +0000
Subject: [PATCH] chore: remove dead EXPIRY_HTLC constant

The EXPIRY_HTLC constant ('expiry_htlc') was defined, exported, and had a
switch case in formatDetailsKey, but this key never appears in any decoded
Lightning data output. BOLT11 tag code 24 correctly maps to
'min_final_cltv_expiry'.

Removing this dead constant reduces confusion for developers who might
otherwise look for 'expiry_htlc' in decoded invoice data.
---
 src/constants/keys.js  | 1 -
 src/utils/keys.js      | 3 ---
 src/utils/keys.test.js | 1 -
 3 files changed, 5 deletions(-)

diff --git a/src/constants/keys.js b/src/constants/keys.js
index 2846506..72a46fa 100644
--- a/src/constants/keys.js
+++ b/src/constants/keys.js
@@ -18,7 +18,6 @@ export const ADDRESS_KEY = 'address';
 export const ADDRESS_HASH_KEY = 'addressHash';
 export const DESCRIPTION_KEY = 'description';
 export const EXPIRE_TIME = 'expire_time';
-export const EXPIRY_HTLC = 'expiry_htlc';
 export const MIN_FINAL_CLTV_EXPIRY = 'min_final_cltv_expiry';
 export const TIME_EXPIRE_DATE_STRING = 'timeExpireDateString';
 export const TIME_EXPIRE_DATE = 'timeExpireDate';
diff --git a/src/utils/keys.js b/src/utils/keys.js
index a25bea2..2391b6a 100644
--- a/src/utils/keys.js
+++ b/src/utils/keys.js
@@ -5,7 +5,6 @@ import {
   PUBKEY_KEY,
   EXPIRE_TIME,
   ADDRESS_KEY,
-  EXPIRY_HTLC,
   SATOSHIS_KEY,
   TAG_CODE_KEY,
   CALLBACK_KEY,
@@ -113,8 +112,6 @@ export const formatDetailsKey = (key) => {
       return 'Code';
     case DESCRIPTION_KEY:
       return 'Description';
-    case EXPIRY_HTLC:
-      return 'Expiry CLTV';
     case TIME_EXPIRE_DATE_STRING:
       return 'Time Expire Date String';
     case TIME_EXPIRE_DATE:
diff --git a/src/utils/keys.test.js b/src/utils/keys.test.js
index 17c5903..4de55b0 100644
--- a/src/utils/keys.test.js
+++ b/src/utils/keys.test.js
@@ -22,7 +22,6 @@ describe('formatDetailsKey', () => {
       { key: 'address', expected: 'Address' },
       { key: 'code', expected: 'Code' },
       { key: 'description', expected: 'Description' },
-      { key: 'expiry_htlc', expected: 'Expiry CLTV' },
       { key: 'timeExpireDateString', expected: 'Time Expire Date String' },
       { key: 'timeExpireDate', expected: 'Time Expire Date' },
       { key: 'timestamp', expected: 'Timestamp' },