docs: fix DEPLOYMENT_EXEDEV.md incomplete vite.config.js example#187
Open
andrerfneves wants to merge 1 commit into
Open
docs: fix DEPLOYMENT_EXEDEV.md incomplete vite.config.js example#187andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
The vite.config.js example in the exe.dev deployment guide omitted the nodePolyfills plugin and build/test configuration. If a user copied the example verbatim, it would break the app at runtime because Buffer and crypto polyfills (required by bolt11.js) would be missing. The example now matches the project's actual vite.config.js while adding the exe.dev-specific server.host, server.port, and server.allowedHosts configuration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
vite.config.jsexample in the exe.dev deployment guide to include thenodePolyfillsplugin andbuild/test` configuration that the project actually requires.Why
The example omitted the
vite-plugin-node-polyfillsplugin, which providesBuffer,crypto, andprocesspolyfills required bybolt11.jsat runtime. If a user copied the example verbatim to configure their exe.dev deployment, the app would silently fail withBuffer is not definederrors.Additionally, the example was missing
build.outDir: 'build'andtestconfiguration, meaning builds would output todistby default (mismatching the project's expectedbuild/directory).Changes
DEPLOYMENT_EXEDEV.md: Updated the vite.config.js example in the "Configure Vite for exe.dev" section to match the project's actual configuration with exe.dev additionsTest Plan
vite.config.jsplus the exe.dev-specificserver.host,server.port, andserver.allowedHostsadditions